From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: mrmacman_g4@mac.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch][1/3] ipc/ BUG -> BUG_ON conversions
Date: Sat, 28 Aug 2004 12:58:16 -0700 [thread overview]
Message-ID: <20040828125816.206ef7fa.akpm@osdl.org> (raw)
In-Reply-To: <20040828162633.GG12772@fs.tum.de>
Adrian Bunk <bunk@fs.tum.de> wrote:
>
> > Anything you put in BUG_ON() must *NOT* have side effects.
> >...
>
> I'd have said exactly the same some time ago, but I was convinced by
> Arjan that if done correctly, a BUG_ON() with side effects is possible
> with no extra cost even if you want to make BUG configurably do nothing.
Nevertheless, I think I'd prefer that we not move code which has
side-effects into BUG_ONs. For some reason it seems neater that way.
Plus one would like to be able to do
BUG_ON(strlen(str) > 22);
and have strlen() not be evaluated if BUG_ON is disabled.
A minor distinction, but one which it would be nice to preserve.
next prev parent reply other threads:[~2004-08-28 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 15:11 [2.6 patch][0/3] BUG -> BUG_ON conversions Adrian Bunk
2004-08-28 15:15 ` [2.6 patch][1/3] ipc/ " Adrian Bunk
2004-08-28 16:05 ` Kyle Moffett
2004-08-28 16:26 ` Adrian Bunk
2004-08-28 16:50 ` Michael Buesch
2004-08-28 19:58 ` Andrew Morton [this message]
2004-08-28 20:22 ` Adrian Bunk
2004-08-28 20:59 ` Jens Axboe
2004-08-28 21:43 ` Matt Mackall
2004-08-28 15:17 ` [2.6 patch][2/3] kernel/ " Adrian Bunk
2004-08-28 16:09 ` Kyle Moffett
2004-08-28 15:18 ` [2.6 patch][3/3] mm/ " Adrian Bunk
2004-08-28 16:32 ` Denis Vlasenko
2004-08-28 20:58 ` Jens Axboe
2004-08-28 21:24 ` Adrian Bunk
2004-08-29 12:03 ` Jens Axboe
2004-08-29 12:18 ` Oliver Neukum
2004-08-29 13:01 ` Jens Axboe
2004-08-29 13:50 ` Adrian Bunk
2004-08-29 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040828125816.206ef7fa.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mrmacman_g4@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.