From: Jens Axboe <axboe@suse.de>
To: Oliver Neukum <oliver@neukum.org>
Cc: Adrian Bunk <bunk@fs.tum.de>,
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch][3/3] mm/ BUG -> BUG_ON conversions
Date: Sun, 29 Aug 2004 15:01:56 +0200 [thread overview]
Message-ID: <20040829130155.GA10279@suse.de> (raw)
In-Reply-To: <200408291418.50255.oliver@neukum.org>
On Sun, Aug 29 2004, Oliver Neukum wrote:
> Am Sonntag, 29. August 2004 14:03 schrieb Jens Axboe:
> > > The intention is, to add an option that lets BUG/BUG_ON/WARN_ON/PAGE_BUG
> > > do nothing. This option should be hidden under EMBEDDED.
> > >
> > > In some environments, this seems to be desirable.
> >
> > That only makes sense if you are using BUG incorrectly. A BUG()
> > condition is something that is non-recoverable, undefining that doesn't
> > make any sense regardless of the environment.
>
> Why not? Giving reports about unrecoverable errors is sensible
> only if the report can be read. On system this is not the case, you
> can just salvage the memory and let it crash.
"Unrecoverable" can quite easily mean "something really bad has
happened, corruption imminent". So maybe you would want BUG/BUG_ON to
restart the box there, the restart-on-panic should help you there.
You're mail is not making a case for defining BUG/BUG_ON to a nop, which
is what the discussion is about.
--
Jens Axboe
next prev parent reply other threads:[~2004-08-29 13:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 15:11 [2.6 patch][0/3] BUG -> BUG_ON conversions Adrian Bunk
2004-08-28 15:15 ` [2.6 patch][1/3] ipc/ " Adrian Bunk
2004-08-28 16:05 ` Kyle Moffett
2004-08-28 16:26 ` Adrian Bunk
2004-08-28 16:50 ` Michael Buesch
2004-08-28 19:58 ` Andrew Morton
2004-08-28 20:22 ` Adrian Bunk
2004-08-28 20:59 ` Jens Axboe
2004-08-28 21:43 ` Matt Mackall
2004-08-28 15:17 ` [2.6 patch][2/3] kernel/ " Adrian Bunk
2004-08-28 16:09 ` Kyle Moffett
2004-08-28 15:18 ` [2.6 patch][3/3] mm/ " Adrian Bunk
2004-08-28 16:32 ` Denis Vlasenko
2004-08-28 20:58 ` Jens Axboe
2004-08-28 21:24 ` Adrian Bunk
2004-08-29 12:03 ` Jens Axboe
2004-08-29 12:18 ` Oliver Neukum
2004-08-29 13:01 ` Jens Axboe [this message]
2004-08-29 13:50 ` Adrian Bunk
2004-08-29 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040829130155.GA10279@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.