From: Ingo Molnar <mingo@elte.hu>
To: Karsten Wiese <annabellesgarden@yahoo.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] voluntary-preempt-2.6.9-rc2-mm1-S1
Date: Sun, 19 Sep 2004 23:49:20 +0200 [thread overview]
Message-ID: <20040919214920.GA8616@elte.hu> (raw)
In-Reply-To: <200409192311.37639.annabellesgarden@yahoo.de>
* Karsten Wiese <annabellesgarden@yahoo.de> wrote:
> Am Sonntag 19 September 2004 22:48 schrieb Ingo Molnar:
> >
> > The point is to let gettimeofday(0,1) start tracing and
> > gettimeofday(0,0) stop tracing - a system-call-controlled tracing
> > facility (if trace_enabled=2). This was used to trace weird latencies
> > before, but it's not the normal mode of operation.
> >
> Ok. The other point is a page_fault being generated later on in
> sys_gettimeofday() if tz is not reset:
> >>>>
> if (unlikely(tz != NULL)) {
> ^^
> if (copy_to_user(tz, &sys_tz, sizeof(sys_tz)))
> return -EFAULT;
> }
> <<<<
yeah - it's a bit ugly. The right thing is to return from that branch.
Ingo
next prev parent reply other threads:[~2004-09-19 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-19 20:32 [patch] voluntary-preempt-2.6.9-rc2-mm1-S1 Karsten Wiese
2004-09-19 20:48 ` Ingo Molnar
2004-09-19 21:11 ` Karsten Wiese
2004-09-19 21:49 ` Ingo Molnar [this message]
2004-09-19 21:46 ` Ingo Molnar
2004-09-19 22:36 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-09-20 22:16 Svetoslav Slavtchev
2004-09-20 21:16 Shane Shrybman
2004-09-21 7:32 ` Ingo Molnar
2004-09-21 15:37 ` Shane Shrybman
2004-09-21 15:59 ` Shane Shrybman
2004-09-06 11:06 [patch] voluntary-preempt-2.6.9-rc1-bk12-R6 Ingo Molnar
2004-09-06 11:48 ` Rafael J. Wysocki
2004-09-06 12:25 ` Alexander Nyberg
2004-09-06 12:29 ` Ingo Molnar
2004-09-07 9:26 ` [patch] voluntary-preempt-2.6.9-rc1-bk12-R7 Ingo Molnar
2004-09-07 11:57 ` [patch] voluntary-preempt-2.6.9-rc1-bk12-R8 Ingo Molnar
2004-09-07 22:59 ` Lee Revell
2004-09-08 8:20 ` [patch] voluntary-preempt-2.6.9-rc1-bk12-R9 Ingo Molnar
2004-09-08 22:37 ` Lee Revell
2004-09-09 6:17 ` [patch] voluntary-preempt-2.6.9-rc1-bk12-S0 Ingo Molnar
2004-09-19 12:26 ` [patch] voluntary-preempt-2.6.9-rc2-mm1-S1 Ingo Molnar
2004-09-19 17:05 ` Felipe Alfaro Solana
2004-09-20 17:14 ` K.R. Foley
2004-09-20 19:48 ` Ingo Molnar
2004-09-21 2:25 ` K.R. Foley
2004-09-20 19:47 ` Magnus Määttä
2004-09-21 18:24 ` K.R. Foley
2004-09-21 19:21 ` Ingo Molnar
2004-09-21 19:37 ` K.R. Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040919214920.GA8616@elte.hu \
--to=mingo@elte.hu \
--cc=annabellesgarden@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.