All of lore.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Cal Peake <cp@absolutedigital.net>
Cc: Jan Dittmer <j.dittmer@portrix.net>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	NetDev Mailing List <netdev@oss.sgi.com>,
	proski@gnu.org, hermes@gibson.dropbear.id.au
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
Date: Mon, 11 Oct 2004 14:16:03 +0100	[thread overview]
Message-ID: <20041011131603.GU23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0410110819370.8480@linaeum.absolutedigital.net>

On Mon, Oct 11, 2004 at 08:23:35AM -0400, Cal Peake wrote:
> On Mon, 11 Oct 2004, Jan Dittmer wrote:
> 
> > Cal Peake wrote:
> > 
> > >  	inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \
> > > -	readw((hw)->iobase + ( (off) << (hw)->reg_spacing )))
> > > +	readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing )))
> > >  #define hermes_write_reg(hw, off, val) do { \
> > 
> > Isn't the correct fix to declare iobase as (void __iomem *) ?
> 
> iobase is an unsigned long, declaring it as a void pointer is prolly not 
> what we want to do here. The typecast seems proper. A lot of other drivers 
> do this as well thus it must be proper ;-)

Typecast is not a proper solution here.   Folks, there are cleanups underway
for all that mess, but it's not _that_ simple.

And adding casts to shut the warnings up is wrong in 99% of cases.

  parent reply	other threads:[~2004-10-11 13:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-11 11:34 [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Cal Peake
2004-10-11 11:54 ` Jan Dittmer
2004-10-11 12:04   ` Ricky lloyd
2004-10-11 12:31     ` David Gibson
2004-10-11 12:42       ` Cal Peake
2004-10-11 13:18       ` Borislav Petkov
2004-10-11 13:33         ` viro
2004-10-11 12:23   ` Cal Peake
2004-10-11 12:29     ` Jan Dittmer
2004-10-11 12:32       ` David Gibson
2004-10-11 12:39         ` Jan Dittmer
2004-10-11 12:49           ` Ben Dooks
2004-10-11 13:16     ` viro [this message]
2004-10-11 14:16       ` Cal Peake
2004-10-11 13:12 ` Pavel Roskin
2004-10-11 14:04   ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041011131603.GU23987@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=cp@absolutedigital.net \
    --cc=hermes@gibson.dropbear.id.au \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.