All of lore.kernel.org
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: herbert@gondor.apana.org.au
Cc: davem@davemloft.net, acme@conectiva.com.br, netdev@oss.sgi.com,
	yoshfuji@linux-ipv6.org
Subject: Re: Bug in ipv6_ifa_notify?
Date: Mon, 08 Nov 2004 08:30:03 -0500 (EST)	[thread overview]
Message-ID: <20041108.083003.119488506.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20041108061529.GA1774@gondor.apana.org.au>

In article <20041108061529.GA1774@gondor.apana.org.au> (at Mon, 8 Nov 2004 17:15:29 +1100), Herbert Xu <herbert@gondor.apana.org.au> says:

> Hi:
> 
> I'm reviewing the changes between 2.6.8.1 and 2.6.9.  The following
> change caught my eye:
> 
> # ChangeSet
> #   2004/08/17 11:25:16+09:00 yoshfuji@linux-ipv6.org
> #   [IPV6] refer inet6 device via corresponding local route from address structure.
> 
> In particular, it changed the handling of RTM_NEWADDR in ipv6_ifa_notify.
> Previously if you received duplicate RTM_NEWADDR notifications
> ip6_rt_addr_add would allocate a new rt and then free it since
> ip6_ins_rt would fail.
> 
> With the new code, it will call ip6_ins_rt on the *same* rt
> again which will cause it to be dst_free'd.  I don't see any
> way for this to lead to dst underflows yet, but it'll certainly
> corrupt the routing table since dst_free modifies rt->u.next.
> 
> Now the question is is it possible to get dupliate RTM_NEWADDR
> notifications?

It used to (before http://linux.bkbits.net:8080/linux-2.5/cset@41216bc8qWlBbT2LRIeGJegBQQxczg).
But, it does not happen now; RTM_NEWADDR notification is called 
 1. when we has successfully finished DAD
or
 2. if the interface does not need DAD

We've tested simple (but including multiple multiple) up/down case.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

      parent reply	other threads:[~2004-11-08 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-08  6:15 Bug in ipv6_ifa_notify? Herbert Xu
2004-11-08  7:34 ` Herbert Xu
2004-11-08 12:10   ` Herbert Xu
2004-11-08 20:37     ` Herbert Xu
2004-11-09 11:48       ` Herbert Xu
2004-11-09 14:57         ` YOSHIFUJI Hideaki / 吉藤英明
2004-11-09 20:35           ` Herbert Xu
2004-11-09 21:04             ` YOSHIFUJI Hideaki / 吉藤英明
2004-11-08 13:30 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041108.083003.119488506.yoshfuji@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=acme@conectiva.com.br \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.