On Fri, Nov 19, 2004 at 09:09:51PM +0100, maximilian attems wrote:
> On Tue, 09 Nov 2004, Stefan Sperling wrote:
> > 
> > Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
> > 
> > --- drivers/net/wireless/atmel_cs.c.orig	2004-11-09 20:40:21.974926616 +0100
> > +++ drivers/net/wireless/atmel_cs.c	2004-11-08 23:10:14.000000000 +0100
> please as described in Documentation/SubmittingPatches
> add one level. thanks :)
 
ouch!

> you send on the same driver multiple patches,
> is the newere one the better, what's their differences?

sorry, my mistake. the newer one is better.
The difference is file permissions for /sys entries.
The older patch exposed more variables as writable (0644),
while the newer one should only make debug and verbosity flags
writeable.

Unfortunately I had a hard drive crash last week and I thus cannot quickly
re-send the patches with -p1.
So I'd suggest editing the diff directly, like so:
--- a/drivers/net/wireless/atmel_cs.c.orig	2004-11-09 20:40:21.974926616 +0100
+++ b/drivers/net/wireless/atmel_cs.c	2004-11-08 23:10:14.000000000 +0100

regards
stefan