From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent Date: Tue, 24 Feb 2015 04:10:34 +0100 Message-ID: <2004494.FgxmON1ogB@xps13> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <2302266.QHkfKt2YM8@xps13> <54EBE934.8080707@sts.kz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Yerden Zhumabekov Return-path: In-Reply-To: <54EBE934.8080707-8EHiFRVJVgQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-24 09:00, Yerden Zhumabekov: >=20 > 23.02.2015 23:36, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > 2015-02-19 15:21, Bruce Richardson: > >> Confirmed, this worked for me too. > >> Looking at the patches, they look good. However, one thing I think= we are missing > >> is a unit test to verify that all our CRC implementations give the= same result. > >> That would be useful as a sanity check of the software fallback es= pecially. The > >> existing hash tests, test the hash table implementation rather tha= n the > >> mathematical argorithm used to compute the hash values. > >> > >> Overall, though, software fallback for CRC is something well worth= while having. > >> > >> Series Acked-by: Bruce Richardson > > Applied, thanks > > > > Note: running doxygen compilation helped me to find and fix a small= > > mismatch (parameter alg was flag in comment). >=20 > Thanks, Bruce, Thomas. >=20 > As for yielding the same hash value, I made a test which runs every > CRC32 implementation across a number of randomly generated data sets.= > Results are equal on my trial run. >=20 > I can post a patch for test_hash.c a bit later if this kind of check > suffices. Yes, seems interesting. Thanks