All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 2.6] drivers/i2c/chips/it87.c: use dynamic
Date: Sun, 05 Jun 2005 20:42:05 +0000	[thread overview]
Message-ID: <20050605204238.2cdbbbc1.khali@linux-fr.org> (raw)
In-Reply-To: <20050605115325.27cd4429.khali@linux-fr.org>

Hi Yani,

> From what I recall Greg was 'inspired' ;-) by your code to find a nice
> way to aggregate the attributes into arrays, and hence it didn't get
> applied right away. If we haven't got some nice solution for that at
> the moment then this might as well be applied, although I do wonder if
> creating an array and attribute group manually and registering all the
> attributes as a group would be cleaner for now?

Ah, thanks for reminding me, I had somehow forgotten that episode.

However, I have plans to modify the it87 driver to only create the sysfs
files for channels which are really in use [1]. For example, I have an
IT8705F chip on my new motherboard, which has 3 unused voltage channels,
2 unused temperature channels and 1 unused fan channel. The driver will
still create the sysfs interface for them at the moment. I think this
isn't good. So it would probably be wiser to wait for me to implement
this, and then see whether using arrays of attributes still makes sense
(and how), rather than the other way around.

So I think we should apply the currently available patch for the it87
driver, and work on top of that later as time permits.

[1] Actually I have many more plans for the it87 driver than just this
one. It's amazing how easier it is to hack on any given driver once you
do have hardware to test your changes :)

Thanks,
-- 
Jean Delvare

  parent reply	other threads:[~2005-06-05 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-05 11:52 [lm-sensors] [PATCH 2.6] drivers/i2c/chips/it87.c: use dynamic Jean Delvare
2005-06-05 20:31 ` Yani Ioannou
2005-06-05 20:42 ` Jean Delvare [this message]
2005-06-05 20:45 ` Yani Ioannou
2005-06-06  9:17 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050605204238.2cdbbbc1.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.