All of
 help / color / mirror / Atom feed
From: Andrew Morton <>
To: Hal Rosenstock <>
Subject: Re: [PATCH 0/29v2] InfiniBand core update
Date: Tue, 12 Jul 2005 15:38:59 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hal Rosenstock <> wrote:
> On Mon, 2005-07-11 at 23:11, Andrew Morton wrote:
> > Well I was asking.  Do you guys think that this material is appropriate to
> > and safe enough for 2.6.13?
> I used your versions of the patches (Tom's ucm one is needed and you
> added that). I also back ported the trailing whitespace elimination
> changes.
> I just completed a regression test including uCM, CM, RMPP, OpenSM,
> IPoIB and it looks good to me.

OK, well the timing of a merge is mainly up to you guys, especially as the
subsystem is pretty raw and you're the only people who use it ;)

Two things from a quick scan:

a) In many places the patch does

	if (p)

   But kfree(0) is permitted.  The cleanup police will be after you at
   some stage - it'd be best to fix those things up immediately.

b) The patch exports a ton of symbols to non-GPL modules:



  reply	other threads:[~2005-07-12 22:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-11 19:30 [PATCH 0/29v2] InfiniBand core update Hal Rosenstock
2005-07-11 19:53 ` David S. Miller
2005-07-12  0:05 ` Andrew Morton
2005-07-12  2:45   ` Hal Rosenstock
2005-07-12  3:11     ` Andrew Morton
2005-07-12  9:43       ` Hal Rosenstock
2005-07-12 22:15       ` Hal Rosenstock
2005-07-12 22:38         ` Andrew Morton [this message]
2005-07-12 22:51           ` Hal Rosenstock
2005-07-12  3:12     ` David S. Miller
2005-07-12  9:11       ` Hal Rosenstock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.