From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [autofs] [RFC PATCH]autofs4: hang and proposed fix Date: Sun, 4 Dec 2005 12:56:12 +0000 Message-ID: <20051204125612.GA28229@infradead.org> References: <1133315771.8978.65.camel@lade.trondhjem.org> <438E0C66.6040607@us.ibm.com> <1133384015.8974.35.camel@lade.trondhjem.org> <438E1A05.7000308@us.ibm.com> <438F251B.7060602@us.ibm.com> <43906968.6080508@us.ibm.com> <1133547148.8976.25.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ian Kent , Will Taber , Jeff Moyer , Ram Pai , autofs mailing list , linux-fsdevel Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:41155 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932210AbVLDM4b (ORCPT ); Sun, 4 Dec 2005 07:56:31 -0500 To: Trond Myklebust Content-Disposition: inline In-Reply-To: <1133547148.8976.25.camel@lade.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Dec 02, 2005 at 01:12:27PM -0500, Trond Myklebust wrote: > On Sat, 2005-12-03 at 01:29 +0800, Ian Kent wrote: > > > It's sufficient to recognize the nameidata struct is NULL on a call > > from lookup_hash nothing more that I'm aware of is needed. If that changes > > then of course autofs will need to be changed. autofs also makes > > assumptions about what flags are set for different reasons. > > Consider those cases where the VFS calls ->lookup()/->d_revalidate() > with the nameidata argument set to NULL to be bugs. They are pretty much > all slated to be fixed soon in order to enable features like read-only > bind mounts etc. They are still NULL in exactly one case: lookup_one_len. Given the design of lookup_one_len we can't get at a nameidata there at all.