All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-scsi@vger.kernel.org, patmans@us.ibm.com,
	adq_dvb@lidskialf.net, linux1394-devel@lists.sourceforge.net,
	James.Bottomley@steeleye.com
Subject: Re: linux kernel panic when ejecting ieee1394 ipod
Date: Sat, 10 Dec 2005 09:48:33 +0100	[thread overview]
Message-ID: <20051210084832.GS26185@suse.de> (raw)
In-Reply-To: <200512091938.jB9JbnnQ025362@einhorn.in-berlin.de>

On Fri, Dec 09 2005, Stefan Richter wrote:
> scsi: dont allow DMA_TO_DEVICE with zero data length
> 
> When preparing a request in scsi_lib or in a SCSI high-level driver,
> always set a transfer direction of DMA_NONE if data length is zero,
> even for alleged write requests. (Extended patch derived from Jens
> Axboe's version.)
> 
> Write requests with request buffer length == 0 lead to kernel panic
> or oops if channeled through sbp2:
> http://marc.theaimsgroup.com/?l=linux1394-devel&m=113399994920181
> http://marc.theaimsgroup.com/?l=linux1394-user&m=112152701817435
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

My quick grep just showed the one, I'd encourage you to turn this into a
static inline function instead of duplicating the same code again 3 (or
more) times.

-- 
Jens Axboe


  parent reply	other threads:[~2005-12-10  8:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200512072358.15398.adq_dvb@lidskialf.net>
2005-12-08  1:17 ` linux kernel panic when ejecting ieee1394 ipod Stefan Richter
2005-12-08  1:57 ` Andrew de Quincey
     [not found] ` <200512080119.48740.adq@lidskialf.net>
2005-12-08  1:59   ` Andrew de Quincey
2005-12-08  2:09     ` Andrew de Quincey
2005-12-08  2:44       ` Stefan Richter
2005-12-08  3:19         ` Andrew de Quincey
2005-12-08  7:52           ` Stefan Richter
2005-12-08 19:27             ` Stefan Richter
2005-12-08 17:34         ` Patrick Mansfield
2005-12-08 19:25           ` Stefan Richter
2005-12-09 13:37           ` Jens Axboe
2005-12-09 13:42             ` Jens Axboe
2005-12-09 18:39               ` Stefan Richter
2005-12-09 19:35                 ` Stefan Richter
2005-12-09 22:45                   ` James Bottomley
2005-12-10 18:20                     ` Christoph Hellwig
2005-12-13 20:44                     ` Stefan Richter
2005-12-13 20:54                       ` Jens Axboe
2005-12-10  8:48                   ` Jens Axboe [this message]
2005-12-10  9:28                     ` Christoph Hellwig
2005-12-10 10:55                       ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051210084832.GS26185@suse.de \
    --to=axboe@suse.de \
    --cc=James.Bottomley@steeleye.com \
    --cc=adq_dvb@lidskialf.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=patmans@us.ibm.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.