From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750796AbVLKW6S (ORCPT ); Sun, 11 Dec 2005 17:58:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750802AbVLKW6R (ORCPT ); Sun, 11 Dec 2005 17:58:17 -0500 Received: from omx2-ext.sgi.com ([192.48.171.19]:25489 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S1750796AbVLKW6R (ORCPT ); Sun, 11 Dec 2005 17:58:17 -0500 Date: Sun, 11 Dec 2005 14:57:40 -0800 From: Paul Jackson To: ebiederm@xmission.com (Eric W. Biederman) Cc: akpm@osdl.org, zwane@arm.linux.org.uk, ashok.raj@intel.com, ak@suse.de, davej@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Don't attempt to power off if power off is not implemented. Message-Id: <20051211145740.32284a45.pj@sgi.com> In-Reply-To: References: <20051127135833.GH20775@brahms.suse.de> Organization: SGI X-Mailer: Sylpheed version 2.1.7 (GTK+ 2.4.9; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > For architectures like alpha that don't implement the pm_power_off > variable pm_power_off is declared in linux/pm.h and it is a generic > part of our power management code, and all architectures should > implement it. > > ... > > Andrew can you pick this up and put this in the mm tree. Kernels > that don't compile or don't power off seem saner than kernels that > oops or panic. Ok - so now you've broken alpha build ;(. Yes - as your patch comment explains, the alternatives suck worse. I'll send a patch that provides a NULL pm_power_off pointer for alpha, which in my 43 seconds of deep analysis of this issue, seems to be the thing to do for arch's that don't define a useful pm_power_off. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401