From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750817AbVLKTbW (ORCPT ); Sun, 11 Dec 2005 14:31:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750819AbVLKTbV (ORCPT ); Sun, 11 Dec 2005 14:31:21 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:52748 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1750817AbVLKTbU (ORCPT ); Sun, 11 Dec 2005 14:31:20 -0500 Date: Sun, 11 Dec 2005 20:31:18 +0100 From: Adrian Bunk To: linux-kernel@vger.kernel.org, tony.luck@intel.com, linux-ia64@vger.kernel.org, matthew@wil.cx, grundler@parisc-linux.org, parisc-linux@parisc-linux.org, paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, dwmw2@infradead.org Cc: linux-mtd@lists.infradead.xn--org-boa Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Message-ID: <20051211193118.GR23349@stusta.de> References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051211192109.GA22537@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 11, 2005 at 07:21:10PM +0000, Russell King wrote: > On Sun, Dec 11, 2005 at 07:52:12PM +0100, Adrian Bunk wrote: > > defconfig's shouldn't set CONFIG_BROKEN=y. > > NACK. This changes other configuration options in addition, for example > in collie_defconfig: > > -CONFIG_MTD_OBSOLETE_CHIPS=y > -# CONFIG_MTD_AMDSTD is not set > -CONFIG_MTD_SHARP=y > -# CONFIG_MTD_JEDEC is not set That's not a problem introduced by my patch. Either the depency of MTD_OBSOLETE_CHIPS on BROKEN is correct (in which case CONFIG_MTD_OBSOLETE_CHIPS=y wouldn't bring you anything), or the dependency on BROKEN is not correct and should be corrected. David, can you comment on this issue? > Russell King cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Date: Sun, 11 Dec 2005 19:31:18 +0000 Subject: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Message-Id: <20051211193118.GR23349@stusta.de> List-Id: References: <20051211185212.GQ23349@stusta.de> <20051211192109.GA22537@flint.arm.linux.org.uk> In-Reply-To: <20051211192109.GA22537@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org, tony.luck@intel.com, linux-ia64@vger.kernel.org, matthew@wil.cx, grundler@parisc-linux.org, parisc-linux@parisc-linux.org, paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, dwmw2@infradead.org Cc: linux-mtd@lists.infradead.xn--org-boa On Sun, Dec 11, 2005 at 07:21:10PM +0000, Russell King wrote: > On Sun, Dec 11, 2005 at 07:52:12PM +0100, Adrian Bunk wrote: > > defconfig's shouldn't set CONFIG_BROKEN=y. > > NACK. This changes other configuration options in addition, for example > in collie_defconfig: > > -CONFIG_MTD_OBSOLETE_CHIPS=y > -# CONFIG_MTD_AMDSTD is not set > -CONFIG_MTD_SHARP=y > -# CONFIG_MTD_JEDEC is not set That's not a problem introduced by my patch. Either the depency of MTD_OBSOLETE_CHIPS on BROKEN is correct (in which case CONFIG_MTD_OBSOLETE_CHIPS=y wouldn't bring you anything), or the dependency on BROKEN is not correct and should be corrected. David, can you comment on this issue? > Russell King cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed