From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tristan Gingold Subject: Re: [PATCH] xencons missing string allocation Date: Mon, 12 Dec 2005 11:40:24 +0200 Message-ID: <200512121040.25062.Tristan.Gingold@bull.net> References: <1134153451.6136.14.camel@tdi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1134153451.6136.14.camel@tdi> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Alex Williamson , xen-devel List-Id: xen-devel@lists.xenproject.org Le Vendredi 09 D=C3=A9cembre 2005 19:37, Alex Williamson a =C3=A9crit : > I was trying to boot dom0 w/ "xencons=3DttyS1 console=3DttyS1". It gi= ves > some weird error messages: > > Warning: dev (ttyS2) tty->count(2) !=3D #fd's(1) in release_dev > Warning: dev (ttyS2) tty->count(3) !=3D #fd's(1) in tty_open > > And blows up with a page fault. The page fault is because we don't > actually allocate a buffer for the tty driver name. The patch below > fixes that problem. Using xencons=3DttyS1 still doesn't quite work and > prints lots of the above error messages, but at least it doesn't crash > dom0 now. Patch vs xen-unstable.hg. Thanks, Why not using a static buffer ? Tristan.