All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: hch@lst.de
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/3] move rtc compat ioctl handling to fs/compat_ioctl.c
Date: Tue, 13 Dec 2005 14:48:54 -0800 (PST)	[thread overview]
Message-ID: <20051213.144854.73497707.davem@davemloft.net> (raw)
In-Reply-To: <20051213172312.GA16392@lst.de>

From: Christoph Hellwig <hch@lst.de>
Date: Tue, 13 Dec 2005 18:23:12 +0100

> This patch implements generic handling of RTC_IRQP_READ32, RTC_IRQP_SET32,
> RTC_EPOCH_READ32 and RTC_EPOCH_SET32 in fs/compat_ioctl.c.  It's based on
> the x86_64 code which needed a little massaging to be endian-clean.
> 
> parisc used COMPAT_IOCTL or generic w_long handlers for these whichce
> is wrong and can't work because the ioctls encode sizeof(unsigned long)
> in their ioctl number.  parisc also duplicated COMPAT_IOCTL entries for
> other rtc ioctls which I remove in this patch, too.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me.

      parent reply	other threads:[~2005-12-13 22:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 17:23 [PATCH 1/3] move rtc compat ioctl handling to fs/compat_ioctl.c Christoph Hellwig
2005-12-13 17:30 ` Matthew Wilcox
2005-12-13 22:48 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213.144854.73497707.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.