All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] i2cdetect fails on a Asus P5ND2-Sli Deluxe
Date: Wed, 14 Dec 2005 19:16:20 +0000	[thread overview]
Message-ID: <20051214201620.25edfc9f.khali@linux-fr.org> (raw)
In-Reply-To: <4399D312.1010109@free.fr>

Hi Fred,

> That works much better !
> I don't have 1024 MB but 1 24 MB : 0 does not appears.
> I don't know why.

Looks like a bug in xsensors, it has code to drop leading zeroes in
memory module sizes, but that code is broken and actually strips all
zeroes, not just leading ones. 1024 is the first power of 2 which needs
a zero, so I guess the bug went unnoticed because even now, 1 GB memory
modules are quite rare.

Please give a try to the following patch, which I expect to fix it:

 src/gui.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

--- xsensors-0.47.orig/src/gui.c	2005-12-14 19:44:10.000000000 +0100
+++ xsensors-0.47/src/gui.c	2005-12-14 19:44:36.000000000 +0100
@@ -460,13 +460,11 @@
                                  (widget) ], theme, x, highLow, 
                                  54, 0, 18, 30 );
                     
-                if ( result >= 100 ) {
+                if ( result >= 100 || x != 198 ) {
                     curInt = result / 100;
                     result = result % 100;
             
                     get_pm_location( curInt, &x );
-                } else {
-                    x = 198;
                 }
             
                 gdk_draw_drawable( widget->window, 
@@ -474,13 +472,11 @@
                                  (widget) ], theme, x, highLow, 
                                  72, 0, 18, 30 );
 
-                if ( result >= 10 ) {
+                if ( result >= 10 || x != 198 ) {
                     curInt = result / 10;
                     result = result % 10;
             
                     get_pm_location( curInt, &x );
-                } else {
-                    x = 198;
                 }
             
                 gdk_draw_drawable( widget->window, 


> PS :  xsensors works fine, but sensord still complains :
> Dec 13 23:25:01 marsu sensord: Adapter: SMBus nForce2 adapter at 5000
> Dec 13 23:25:01 marsu sensord: Algorithm: Unavailable from sysfs

Note that it isn't an error. You may ignore any message related to
algorithms safely, see my other post. We'll drop them soon (I hope).

> Dec 13 23:25:01 marsu sensord:   Memory type: Invalid
> Dec 13 23:25:01 marsu sensord:   Memory size (MB): Invalid 14 10 97 4

Lack of support for DDR2 SDRAM. We have dropped eeprom support entirely
from sensord in the next release anyway. There's little interest in
continuously polling read-only data, isn't it?

> PS2 : why it87 is not supported by xsensors ?

it87 is. You have (I guess) it8712, which is only supported in xsensors
0.47, while Sarge ships 0.46. Try 0.47 with my two patches and it
should work fine.

-- 
Jean Delvare


  parent reply	other threads:[~2005-12-14 19:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 18:55 [lm-sensors] i2cdetect fails on a Asus P5ND2-Sli Deluxe fred
2005-12-09 20:35 ` Jean Delvare
2005-12-11 21:03 ` fred
2005-12-12 19:27 ` Jean Delvare
2005-12-13 18:45 ` fred
2005-12-13 19:07 ` fred
2005-12-13 19:27 ` fred
2005-12-13 22:03 ` Jean Delvare
2005-12-13 22:06 ` fred
2005-12-13 22:31 ` fred
2005-12-14 19:03 ` Jean Delvare
2005-12-14 19:16 ` Jean Delvare [this message]
2005-12-14 20:04 ` fred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214201620.25edfc9f.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.