All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] X1205 cleanup
Date: Wed, 28 Dec 2005 22:28:19 +0000	[thread overview]
Message-ID: <20051228232819.545163e8.khali@linux-fr.org> (raw)
In-Reply-To: <20051213214058.2781e657@inspiron>

Hi Alessandro,

> > What is the point of your cleanup? As I understand it, the driver is no
> > more exporting any functionality to the rest of the kernel. As it has no
> > user-space interface either, this means that the only thing the driver
> > is useful for is running x1205_hctosys at runtime - and even this only
> > happens if the module parameter hctosys has been set, which isn't the
> > default.
> 
> This cleanup was in preparation for the new rtc subsystem I'm writing,
> so I thought it was better to leave those functions there.

In that case, you are doing things in the wrong order. You should first
introduce your new RTC subsystem (which I think is a good idea,
although I lack time to actually look into your implementation), then
convert your driver directly to use it. Having an intermediate state
where your driver is mostly useless doesn't make much sense.

Thanks,
-- 
Jean Delvare


      parent reply	other threads:[~2005-12-28 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 20:40 [lm-sensors] [PATCH] X1205 cleanup Alessandro Zummo
2005-12-27 11:13 ` Jean Delvare
2005-12-27 23:40 ` Alessandro Zummo
2005-12-28 22:28 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051228232819.545163e8.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.