From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH net-next 0/2] fixes for ipsec selftests Date: Thu, 21 Jun 2018 23:50:36 -0700 Message-ID: <20059528-5d1d-cb7c-26f8-f9055bd807c2@oracle.com> References: <1529473363-4036-1-git-send-email-shannon.nelson@oracle.com> <20180622.134913.2049651808540037401.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, anders.roxell@linaro.org To: David Miller Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:60490 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbeFVGup (ORCPT ); Fri, 22 Jun 2018 02:50:45 -0400 In-Reply-To: <20180622.134913.2049651808540037401.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/21/2018 9:49 PM, David Miller wrote: > From: Shannon Nelson > Date: Tue, 19 Jun 2018 22:42:41 -0700 > >> A couple of bad behaviors in the ipsec selftest were pointed out >> by Anders Roxell and are addressed here. >> >> Shannon Nelson (2): >> selftests: rtnetlink: hide complaint from terminated monitor >> selftests: rtnetlink: use a local IP address for IPsec tests > > Series applied, but I wonder about patch #2. > > The idea is that we don't make modifications to the actual system > networking configuration and therefore make changes that can't > possibly disrupt connectivity for the system under test. > > Using a configured local IP address seems to subvert that. Yeah, I'm not so thrilled with it either. I've got a couple more changes coming Real Soon Now that extend netdevsim and add a couple of tests for ipsec-hw-offload, so while I finish those up I can change this again and make use of netdevsim to leave existing devices alone. For that matter, if you want to cut down on patch thrash, just drop patch 2. sln