From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129AbWE3Bdt (ORCPT ); Mon, 29 May 2006 21:33:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932095AbWE3Bcl (ORCPT ); Mon, 29 May 2006 21:32:41 -0400 Received: from smtp.osdl.org ([65.172.181.4]:12225 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932109AbWE3BcB (ORCPT ); Mon, 29 May 2006 21:32:01 -0400 Date: Mon, 29 May 2006 18:36:08 -0700 From: Andrew Morton To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, arjan@infradead.org, "David S. Miller" Subject: Re: [patch 52/61] lock validator: special locking: af_unix Message-Id: <20060529183608.19308b7c.akpm@osdl.org> In-Reply-To: <20060529212719.GZ3155@elte.hu> References: <20060529212109.GA2058@elte.hu> <20060529212719.GZ3155@elte.hu> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2006 23:27:19 +0200 Ingo Molnar wrote: > From: Ingo Molnar > > teach special (recursive) locking code to the lock validator. Has no > effect on non-lockdep kernels. > > (includes workaround for sk_receive_queue.lock, which is currently > treated globally by the lock validator, but which be switched to > per-address-family locking rules.) > > ... > > > - spin_lock(&sk->sk_receive_queue.lock); > + spin_lock_bh(&sk->sk_receive_queue.lock); Again, a bit of a show-stopper. Will the real fix be far off?