From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422674AbWHXVat (ORCPT ); Thu, 24 Aug 2006 17:30:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422676AbWHXVat (ORCPT ); Thu, 24 Aug 2006 17:30:49 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:29446 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1422674AbWHXVas (ORCPT ); Thu, 24 Aug 2006 17:30:48 -0400 Date: Thu, 24 Aug 2006 23:30:47 +0200 From: Adrian Bunk To: David Woodhouse Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] Add __global tag where needed. Message-ID: <20060824213047.GR19810@stusta.de> References: <1156429585.3012.58.camel@pmac.infradead.org> <1156433212.3012.120.camel@pmac.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1156433212.3012.120.camel@pmac.infradead.org> User-Agent: Mutt/1.5.12-2006-07-14 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 24, 2006 at 04:26:52PM +0100, David Woodhouse wrote: > This patch just adds the __global tag to functions and variables which > are used from outside the directory in which they're provided, to > prevent -fwhole-program from eating them. > > If we just define __global as a dummy for now, then there's no harm in > applying this patch as-is -- but it's largely pointless without the > Makefile changes. >... Applying this doesn't seem to make much sense until it's clear whether a "build everything except for assembler files at once" approach (that needs less globals) or your current "compile only multi-obj at once" approach (that requires more globals). > dwmw2 cu Adrian -- Gentoo kernels are 42 times more popular than SUSE kernels among KLive users (a service by SUSE contractor Andrea Arcangeli that gathers data about kernels from many users worldwide). There are three kinds of lies: Lies, Damn Lies, and Statistics. Benjamin Disraeli