All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek <konradr@us.ibm.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-scsi@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexis Bruemmer <alexisb@us.ibm.com>
Subject: Re: [PATCH 1/2] Add SATA support to libsas
Date: Fri, 25 Aug 2006 15:43:38 -0400	[thread overview]
Message-ID: <20060825194338.GA6020@andromeda.dapyr.net> (raw)
In-Reply-To: <44DBE943.4080303@us.ibm.com>

On Thu, Aug 10, 2006 at 07:19:47PM -0700, Darrick J. Wong wrote:
> Hook the scsi_host_template functions in libsas to delegate
> functionality to libata when appropriate.
> 
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> 
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index b0705ee..76bbb9f 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c

(...)

>  /* ---------- Domain device ---------- */
> @@ -626,4 +634,8 @@ void sas_unregister_devices(struct sas_h
>  
>  void sas_init_dev(struct domain_device *);
>  
> +extern void sas_target_destroy(struct scsi_target *);
> +extern int sas_slave_alloc(struct scsi_device *);
> +extern int sas_ioctl(struct scsi_device *sdev, int cmd, void __user *arg);
> +

Those should not be 'extern' otherwise the EXPORT_SYMBOL functions 
won't be found when the aic94xx is built as a module.


  parent reply	other threads:[~2006-08-25 19:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-11  2:19 [PATCH 1/2] Add SATA support to libsas Darrick J. Wong
2006-08-11  8:52 ` Jeff Garzik
2006-08-24 22:18   ` James Bottomley
2006-08-22 17:26 ` James Bottomley
2006-08-25 19:43 ` Konrad Rzeszutek [this message]
2006-08-25 20:21   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825194338.GA6020@andromeda.dapyr.net \
    --to=konradr@us.ibm.com \
    --cc=alexisb@us.ibm.com \
    --cc=djwong@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.