All of lore.kernel.org
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: another NUMA build error
Date: Sat, 26 Aug 2006 03:28:34 +0900	[thread overview]
Message-ID: <20060826032834.ead83dec.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20060825103507.4f2d193e.rdunlap@xenotime.net>

On Fri, 25 Aug 2006 10:35:07 -0700
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:

> OK, I prefer option 2 because it is more generic (not hardware-
> specific).  Someone else can prefer option 1 because it is
> hardware-specific.  :)
> 
ok. patch is here. but people who know x86-numa should confirm this.

-Kame
--
compile fix for

In file included from include/asm/mmzone.h:18,
                 from include/linux/mmzone.h:439,
<snip>
include/asm/srat.h:31:2: error: #error CONFIG_ACPI_SRAT not defined, and srat.h header has been included
make[1]: *** [arch/i386/kernel/asm-offsets.s] Error 1

This can happen with CONFIG_NUMA && !CONFIG_ACPI && !CONFIG_X86_NUMAQ

Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

 include/asm-i386/mmzone.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18-rc4/include/asm-i386/mmzone.h
===================================================================
--- linux-2.6.18-rc4.orig/include/asm-i386/mmzone.h
+++ linux-2.6.18-rc4/include/asm-i386/mmzone.h
@@ -14,7 +14,7 @@ extern struct pglist_data *node_data[];
 
 #ifdef CONFIG_X86_NUMAQ
 	#include <asm/numaq.h>
-#else	/* summit or generic arch */
+#elif defined(CONFIG_ACPI_SRAT)/* summit or generic arch */
 	#include <asm/srat.h>
 #endif
 


  reply	other threads:[~2006-08-25 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-25  4:35 another NUMA build error Randy.Dunlap
2006-08-25  5:43 ` KAMEZAWA Hiroyuki
2006-08-25 17:35   ` Randy.Dunlap
2006-08-25 18:28     ` KAMEZAWA Hiroyuki [this message]
2006-08-25 19:06       ` Randy.Dunlap
     [not found]     ` <a762e240608251544t2e15ec8dq5a8f95f02eecb0a4@mail.gmail.com>
2006-08-25 23:01       ` Randy.Dunlap
2006-08-26  1:56         ` KAMEZAWA Hiroyuki
2006-08-26  4:17           ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060826032834.ead83dec.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.