From: Mike Frysinger <vapier@gentoo.org>
To: "Carlos O'Donell" <carlos@systemhalted.org>
Cc: parisc-linux <parisc-linux@lists.parisc-linux.org>
Subject: [parisc-linux] Re: update mman.h in latest glibc cvs
Date: Sat, 26 Aug 2006 17:44:06 -0400 [thread overview]
Message-ID: <200608261744.07651.vapier@gentoo.org> (raw)
In-Reply-To: <119aab440608260809v26134ee2w46e5166168607a5f@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1102 bytes --]
On Saturday 26 August 2006 11:09, Carlos O'Donell wrote:
> I appreciate it if you say "Is this patch correct?" or some indication
> that it is not final. I spend a different amount of time reviewing
> final patches than just initial hacks.
sorry, my mistake ... i'll keep that in mind in the future
> > > Please avoid superflous style changes.
> >
> > it isnt superfluous, it is the "GNU standard" and the way all other arch
> > mman.h headers are done ... so while i personally consider the GNU coding
> > standard complete garbage, glibc is a GNU project and adheres pretty
> > rigidly to the GNU coding standard
>
> I don't see a requirement for left single quote and right single quote
> in comments?
as i said i was simply doing exactly what every other arch port in glibc is
doing ... if you want to keep hppa different, well you're the maintainer ;)
> Thank you. Could you put together another patch please? If you haven't
> done a build test please tell me.
i just do cross-compile builds as my hppa's are too painfully slow to do
development natively :)
-mike
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
prev parent reply other threads:[~2006-08-26 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 4:50 [parisc-linux] update mman.h in latest glibc cvs Mike Frysinger
[not found] ` <200608250928.14815.mszick@morethan.org>
2006-08-25 16:22 ` Grant Grundler
2006-08-25 20:01 ` [parisc-linux] " Carlos O'Donell
2006-08-26 4:59 ` Mike Frysinger
[not found] ` <119aab440608260809v26134ee2w46e5166168607a5f@mail.gmail.com>
2006-08-26 21:44 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608261744.07651.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=carlos@systemhalted.org \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.