From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845AbWH1LxC (ORCPT ); Mon, 28 Aug 2006 07:53:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964839AbWH1LxC (ORCPT ); Mon, 28 Aug 2006 07:53:02 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:24813 "EHLO e3.ny.us.ibm.com") by vger.kernel.org with ESMTP id S964837AbWH1LxA convert rfc822-to-8bit (ORCPT ); Mon, 28 Aug 2006 07:53:00 -0400 From: Arnd Bergmann Organization: IBM Deutschland Entwicklung GmbH To: David Howells Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] Date: Mon, 28 Aug 2006 13:52:57 +0200 User-Agent: KMail/1.9.1 Cc: Sam Ravnborg , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20060825200455.GA2629@uranus.ravnborg.org> <20060825193707.11384.97372.stgit@warthog.cambridge.redhat.com> <22040.1156537104@warthog.cambridge.redhat.com> In-Reply-To: <22040.1156537104@warthog.cambridge.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200608281352.58281.arnd.bergmann@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Friday 25 August 2006 22:18, David Howells wrote: > > > +ifeq ($(CONFIG_MMU),y) > > > +obj-y                      += bounce.o > > > +endif > > > > CONFIG_MMU is a bool so you can do this much more elegant: > > obj-$(CONFIG_MMU) += bounce.o > > In patch 18/18, this changes to: > >         ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) > > So the elegence in the end is irrelevant. You could write it as bounce-$(CONFIG_MMU) += bounce.o obj-$(CONFIG_BLOCK) += $(bounce-y) Arnd <>< From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] Date: Mon, 28 Aug 2006 13:52:57 +0200 Message-ID: <200608281352.58281.arnd.bergmann@de.ibm.com> References: <20060825200455.GA2629@uranus.ravnborg.org> <20060825193707.11384.97372.stgit@warthog.cambridge.redhat.com> <22040.1156537104@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Sam Ravnborg , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from e3.ny.us.ibm.com ([32.97.182.143]:24813 "EHLO e3.ny.us.ibm.com") by vger.kernel.org with ESMTP id S964837AbWH1LxA convert rfc822-to-8bit (ORCPT ); Mon, 28 Aug 2006 07:53:00 -0400 To: David Howells In-Reply-To: <22040.1156537104@warthog.cambridge.redhat.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Friday 25 August 2006 22:18, David Howells wrote: > > > +ifeq ($(CONFIG_MMU),y) > > > +obj-y=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0+=3D bounce.o > > > +endif > >=20 > > CONFIG_MMU is a bool so you can do this much more elegant: > > obj-$(CONFIG_MMU) +=3D bounce.o >=20 > In patch 18/18, this changes to: >=20 > =A0=A0=A0=A0=A0=A0=A0=A0ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) >=20 > So the elegence in the end is irrelevant. You could write it as bounce-$(CONFIG_MMU) +=3D bounce.o obj-$(CONFIG_BLOCK) +=3D $(bounce-y) Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html