From: Jakub Narebski <jnareb@gmail.com>
To: Robert Fitzsimons <robfitz@273k.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH 6/6] gitweb: Make possible to run under mod_perl without ParseHeaders
Date: Thu, 28 Dec 2006 02:12:44 +0100 [thread overview]
Message-ID: <200612280212.45120.jnareb@gmail.com> (raw)
In-Reply-To: <20061228010311.GD6558@localhost>
Robert Fitzsimons wrote:
>> @@ -1854,7 +1976,8 @@ EOF
>> $cgi->hidden(-name => "a") . "\n" .
>> $cgi->hidden(-name => "h") . "\n" .
>> $cgi->popup_menu(-name => 'st', -default => 'commit',
>> - -values => ['commit', 'author', 'committer', 'pickaxe']) .
>> + -values => ['commit', 'author', 'committer',
>> + gitweb_check_feature('pickaxe') ? 'pickaxe' : ()]) .
>> $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) .
>> " search:\n",
>> $cgi->textfield(-name => "s", -value => $searchtext) . "\n" .
>
> This should be a separate patch.
I'm sorry, somehow I missed this.
Besides, it would be better to assign return value to some
variable, to avoid calling gitweb_check_feature again...
--
Jakub Narebski
Poland
prev parent reply other threads:[~2006-12-28 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 22:55 [PATCH 0/6] gitweb: Some mod_perl specific support (but not only) Jakub Narebski
2006-12-27 22:57 ` [PATCH 1/6] gitweb: Separate HTTP header output Jakub Narebski
2006-12-28 1:23 ` Junio C Hamano
2006-12-28 1:28 ` Shawn Pearce
2006-12-27 22:59 ` [PATCH 2/6] gitweb: Add mod_perl version string to "generator" meta header Jakub Narebski
2006-12-27 23:00 ` [PATCH 3/6] gitweb: Precompile CGI routines for mod_perl Jakub Narebski
2006-12-27 23:04 ` [PATCH/RFC 4/6] gitweb: Prepare for mod_perl specific support Jakub Narebski
2006-12-27 23:49 ` [PATCH/RFC 5/6] gitweb: Make possible to run under mod_perl without SetupEnv Jakub Narebski
2006-12-28 0:06 ` [RFC/PATCH 6/6] gitweb: Make possible to run under mod_perl without ParseHeaders Jakub Narebski
2006-12-28 1:03 ` Robert Fitzsimons
2006-12-28 1:12 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612280212.45120.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=robfitz@273k.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.