From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE713C433E0 for ; Mon, 8 Feb 2021 11:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 792DF64E60 for ; Mon, 8 Feb 2021 11:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbhBHLuQ (ORCPT ); Mon, 8 Feb 2021 06:50:16 -0500 Received: from mailoutvs44.siol.net ([185.57.226.235]:38057 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232995AbhBHL2v (ORCPT ); Mon, 8 Feb 2021 06:28:51 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5ABB65222CC; Mon, 8 Feb 2021 12:27:46 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xCUIjupoRsvj; Mon, 8 Feb 2021 12:27:46 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 10562522380; Mon, 8 Feb 2021 12:27:46 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id BEF76522137; Mon, 8 Feb 2021 12:27:45 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Maxime Ripard , Rob Herring , "B.R. Oake" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode Date: Mon, 08 Feb 2021 12:27:45 +0100 Message-ID: <2006991.bPDHmd0WOD@kista> In-Reply-To: <1243888060.510560.1612783497400@ichabod.co-bxl> References: <1243888060.510560.1612783497400@ichabod.co-bxl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne ponedeljek, 08. februar 2021 ob 12:24:57 CET je B.R. Oake napisal(a): > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx > delay config"), Ethernet no longer works on the Orange Pi Plus, > because that commit sets the RX/TX delay according to the phy-mode > property in the device tree, which is "rgmii", the wrong setting > for this board. > > Following the example of others who fixed the same problem for > many other boards, this patch changes the phy-mode to "rgmii-id" > which gets Ethernet working again on this board. > > Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") > Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i") > Signed-off-by: B.R. Oake > --- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jernej Skrabec Thanks! Best regards, Jernej > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/ dts/sun8i-h3-orangepi-plus.dts > index 97f497854e..d05fa679dc 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > @@ -85,7 +85,7 @@ > pinctrl-0 = <&emac_rgmii_pins>; > phy-supply = <®_gmac_3v3>; > phy-handle = <&ext_rgmii_phy>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > > status = "okay"; > }; > -- > 2.20.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2462C433DB for ; Mon, 8 Feb 2021 11:29:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44A1F64E8B for ; Mon, 8 Feb 2021 11:29:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A1F64E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GIWjTIOzxeaWQjEoNsPyZ/so2XstKmoHXE4dNHGAanQ=; b=VJOsFTQUkAK/0uT8i/bOuiU8Z YKcvtpC3F0btnXWQbo/oab/OZovfc0YXa6gQLFr/0uRjb37sI/yEnNC9xHEi13YCv74Zz0WEod+ft 9fFuRqDSxiQFLe+iNaCLO+C6CntAJln9MJT1Y4z0w15p/9Y6ceoJQlCxVMhVP55Q+iT1HHjGohvMR iLA7GfHLp3b6kn6DI/SiPsBdzJRJ6HGkUKqaqp3sfRU1wsxRutjpBMGqp3OKx80Qlpq2HBBVNkolf qYEEdc2S054F8tokJ8HXkVRRsafKcHtiMIRw2U9oEAz8GWXhVslaEvXgcPZMWkytrRclOJRkPBURm W7WQHZdiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94hv-00085V-7X; Mon, 08 Feb 2021 11:27:55 +0000 Received: from mailoutvs6.siol.net ([185.57.226.197] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l94hp-000839-AG for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 11:27:52 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5ABB65222CC; Mon, 8 Feb 2021 12:27:46 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xCUIjupoRsvj; Mon, 8 Feb 2021 12:27:46 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 10562522380; Mon, 8 Feb 2021 12:27:46 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id BEF76522137; Mon, 8 Feb 2021 12:27:45 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Maxime Ripard , Rob Herring , "B.R. Oake" Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode Date: Mon, 08 Feb 2021 12:27:45 +0100 Message-ID: <2006991.bPDHmd0WOD@kista> In-Reply-To: <1243888060.510560.1612783497400@ichabod.co-bxl> References: <1243888060.510560.1612783497400@ichabod.co-bxl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_062749_550930_4AA65FCD X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 08. februar 2021 ob 12:24:57 CET je B.R. Oake napisal(a): > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx > delay config"), Ethernet no longer works on the Orange Pi Plus, > because that commit sets the RX/TX delay according to the phy-mode > property in the device tree, which is "rgmii", the wrong setting > for this board. > > Following the example of others who fixed the same problem for > many other boards, this patch changes the phy-mode to "rgmii-id" > which gets Ethernet working again on this board. > > Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") > Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i") > Signed-off-by: B.R. Oake > --- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jernej Skrabec Thanks! Best regards, Jernej > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/ dts/sun8i-h3-orangepi-plus.dts > index 97f497854e..d05fa679dc 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > @@ -85,7 +85,7 @@ > pinctrl-0 = <&emac_rgmii_pins>; > phy-supply = <®_gmac_3v3>; > phy-handle = <&ext_rgmii_phy>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > > status = "okay"; > }; > -- > 2.20.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel