On Tuesday 30 January 2007 20:38, John W. Linville wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
>
> +	/* Inject a frame using NL80211_ATTR_FLAGS and NL80211_ATTR_FRAME.
> +	 * If kernel sends this, it's a status notification for the injected
> +	 * frame. */
> +	NL80211_CMD_INJECT,
> +
I think drivers that currently support frame injection do it by allowing TX on 
a monitor interface w/ AVS or radiotap header. I would rather have this than 
requiring the use of NL80211 to inject frames since userspace won't have to 
do as much to continue supporting frame injection. It also makes more sense 
to me. Status notification can be done by a 802.11 ACK frame. Radiotap might 
need to be extended to support toggling the ACK frame reporting for TX and 
whatever else userspace wants to set.

[snip]
> +	/* configure device */
> +	NL80211_CMD_CONFIGURE,
> +
> +	/* request configuration */
> +	NL80211_CMD_GET_CONFIG,
> +
> +	/* configuration sent from kernel */
> +	NL80211_CMD_NEW_CONFIG,
> +
Why NEW?

[snip]
> +	/* currently set roaming BSSID */
> +	NL80211_CMD_FIXED_BSSID,
> +
Wasn't immediately obvious to me that this is from GET_FIXED_BSSID.

> +	/* get current association information, if not associated then
> +	 * the BSSID attribute is not present in response */
> +	NL80211_CMD_GET_ASSOCIATION,
> +
> +	/* association notification and response to GET_BSSID */
> +	NL80211_CMD_ASSOCIATION_CHANGED,
> +
I don't see a GET_BSSID. Did you mean GET_ASSOCIATION?

[snip]
> +	/* attributes used for configuration */
> +	/* network ID (pre 802.11 HW) */
> +	NL80211_ATTR_NETWORK_ID,
> +
We really want to support (and port) pre 802.11 drivers?

[snip]
> +	/* SSID of ESS to associate to */
BSS?

> +	NL80211_ATTR_SSID,
> +

[snip]
> + * @list_interfaces: for each interfaces belonging to the wiphy identified
> + *		     by the priv pointer, call the one() function with the
> + *		     given data and the ifindex. This callback is required.
> + *
Do we really have to have this?

Thanks,
-Michael Wu