From: olof@lixom.net (Olof Johansson)
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] [5/9] pasemi: Implement restart
Date: Fri, 2 Feb 2007 12:46:45 -0600 [thread overview]
Message-ID: <20070202184644.GA30912@lixom.net> (raw)
In-Reply-To: <9C45758A-F748-43B2-97F6-E27FE0AC0530@kernel.crashing.org>
On Fri, Feb 02, 2007 at 12:07:42AM -0600, Kumar Gala wrote:
> >- pas_power_off();
> >+ void __iomem *sdcreg;
> >+ printk("Restarting...\n");
> >+ /* XXXOJN This should maybe come out of the device tree */
> >+ sdcreg = ioremap(0xfc101100, 4);
>
> You can't do the ioremap here, restart may get call an oops from
> interrupt context.
Oh, that's right. Will do it in setup instead.
Thanks,
-Olof
next prev parent reply other threads:[~2007-02-02 18:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 4:54 [PATCH] [0/9] PA Semi patches Olof Johansson
2007-02-02 4:54 ` [PATCH] [1/9] pasemi: Default root device Olof Johansson
2007-02-02 22:28 ` Geoff Levand
2007-02-04 22:18 ` Olof Johansson
2007-02-04 22:37 ` Olof Johansson
2007-02-02 4:54 ` [PATCH] [2/9] pasemi: UART udbg support Olof Johansson
2007-02-02 4:54 ` [PATCH] [3/9] pasemi: Machine check handler Olof Johansson
2007-02-04 23:49 ` Benjamin Herrenschmidt
2007-02-05 4:19 ` Olof Johansson
2007-02-02 4:54 ` [PATCH] [4/9] pasemi: Idle loops Olof Johansson
2007-02-03 8:27 ` Arnd Bergmann
2007-02-04 22:25 ` Olof Johansson
2007-02-02 4:54 ` [PATCH] [5/9] pasemi: Implement restart Olof Johansson
2007-02-02 6:07 ` Kumar Gala
2007-02-02 18:46 ` Olof Johansson [this message]
2007-02-02 4:54 ` [PATCH] [6/9] pasemi: SMP timebase sync Olof Johansson
2007-02-02 4:54 ` [PATCH] [7/9] pasemi: Configure DMA controller interrupts Olof Johansson
2007-02-04 23:53 ` Benjamin Herrenschmidt
2007-02-05 4:52 ` Olof Johansson
2007-02-02 4:54 ` [PATCH] [8/9] pasemi: iommu support Olof Johansson
2007-02-02 4:54 ` [PATCH] [9/9] pasemi: defconfig Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202184644.GA30912@lixom.net \
--to=olof@lixom.net \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.