Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

["YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>]

In article <20070205.173258.102576664.davem@davemloft.net> (at Mon, 05 Feb 2007 17:32:58 -0800 (PST)), David Miller <davem@davemloft.net> says:

> From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Date: Tue, 06 Feb 2007 10:24:05 +0900 (JST)
> 
> > > @@ -498,7 +500,8 @@ static void ndisc_send_na(struct net_device *dev, struct neighbour *neigh,
> > >          msg->icmph.icmp6_unused = 0;
> > >          msg->icmph.icmp6_router    = router;
> > >          msg->icmph.icmp6_solicited = solicited;
> > > -        msg->icmph.icmp6_override  = override;
> > > +	msg->icmph.icmp6_override  = override;
> > > +
> > >  
> > >          /* Set the target address. */
> > >  	ipv6_addr_copy(&msg->target, solicited_addr);
> > 
> > Why do you "change" this?
> 
> He edited it, but then reverted his change but in the
> process added proper tab characters :-)  It is easy
> to miss things like this.

I know, you know. :-)

> This whole file has a lot of lines lacking proper tab
> characters.

Yes, I agree, but I think it is different issue, and
maybe, we should check and change other places as well,
in separate patch(es).

--yoshfuji