All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] check for KVM_GET/SET_REG ioctl failures
Date: Tue, 6 Feb 2007 21:39:39 +0200	[thread overview]
Message-ID: <20070206193939.GE4292@rhun.ibm.com> (raw)
In-Reply-To: <45C8D680.3020704-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

On Tue, Feb 06, 2007 at 01:26:56PM -0600, Anthony Liguori wrote:

> Please don't add exit()'s to a library, these are the sort of things
> we should be trying to remove.

I agree on general principles, but do we envision libkvm.a being used
in anything outside qemu? in any case, if not exit(), what would you
suggest? from a quick reading of the code, it doesn't appear feasible
to go on when get or set regs fail.

> In the very least, you should probably expect to see EINTRs.

Hmm, which code path do you have in mind that can return EINTR here?

Cheers,
Muli

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2007-02-06 19:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 18:46 [PATCH] check for KVM_GET/SET_REG ioctl failures Muli Ben-Yehuda
     [not found] ` <20070206184639.GA4292-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>
2007-02-06 19:26   ` Anthony Liguori
     [not found]     ` <45C8D680.3020704-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-02-06 19:39       ` Muli Ben-Yehuda [this message]
     [not found]         ` <20070206193939.GE4292-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>
2007-02-06 20:59           ` Anthony Liguori
     [not found]             ` <45C8EC44.509-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-02-06 21:09               ` Muli Ben-Yehuda
     [not found]                 ` <20070206210926.GI4292-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>
2007-02-06 21:20                   ` Anthony Liguori
2007-02-06 21:35                   ` [PATCH v2] " Muli Ben-Yehuda
2007-02-06 22:36           ` [PATCH] " James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206193939.GE4292@rhun.ibm.com \
    --to=muli-7z/5bgajwgfqt0dzr+alfa@public.gmane.org \
    --cc=aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.