All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] sky2: Yukon Extreme support
Date: Tue, 6 Feb 2007 22:52:56 +0100	[thread overview]
Message-ID: <20070206215256.GA28967@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20070206184855.246345000@linux-foundation.org>

Stephen Hemminger <shemminger@linux-foundation.org> :
[...]
> @@ -289,8 +289,10 @@
>  	struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
>  	u16 ctrl, ct1000, adv, pg, ledctrl, ledover, reg;
>  
> -	if (sky2->autoneg == AUTONEG_ENABLE &&
> -	    !(hw->chip_id == CHIP_ID_YUKON_XL || hw->chip_id == CHIP_ID_YUKON_EC_U)) {
> +	if (sky2->autoneg == AUTONEG_ENABLE
> +	    && !(hw->chip_id == CHIP_ID_YUKON_XL
> +		 || hw->chip_id == CHIP_ID_YUKON_EC_U
> +		 || hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +			if (sky2->autoneg == AUTONEG_ENABLE
> +			    && (hw->chip_id == CHIP_ID_YUKON_XL
> +				|| hw->chip_id == CHIP_ID_YUKON_EC_U
> +				|| hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +	if (hw->chip_id == CHIP_ID_YUKON_XL
> +	    || hw->chip_id == CHIP_ID_YUKON_EC_U
> +	    || hw->chip_id == CHIP_ID_YUKON_EX) {
[...]
> +	if (hw->chip_id == CHIP_ID_YUKON_XL
> +	    || hw->chip_id == CHIP_ID_YUKON_EC_U
> +	    || hw->chip_id == CHIP_ID_YUKON_EX)

Any objection against the use of :

static bool is_yukon_extreme(struct sky2_hw *hw)
{
	return hw->chip_id == CHIP_ID_YUKON_XL ||
		hw->chip_id == CHIP_ID_YUKON_EC_U ||
		hw->chip_id == CHIP_ID_YUKON_EX;
}

?

-- 
Ueimor

  reply	other threads:[~2007-02-06 21:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 18:45 [PATCH 0/7] sky2 v1.12 patches Stephen Hemminger
2007-02-06 18:45 ` [PATCH 1/7] sky2: add Wake On Lan support Stephen Hemminger
2007-02-07  0:20   ` Jeff Garzik
2007-02-06 18:45 ` [PATCH 2/7] sky2: use dev_err for error reports Stephen Hemminger
2007-02-06 18:45 ` [PATCH 3/7] sky2: TSO support for EC_U Stephen Hemminger
2007-02-06 18:45 ` [PATCH 4/7] sky2: safer transmit timeout Stephen Hemminger
2007-02-06 18:45 ` [PATCH 5/7] sky2: Yukon Extreme support Stephen Hemminger
2007-02-06 21:52   ` Francois Romieu [this message]
2007-02-06 22:07     ` Stephen Hemminger
2007-02-06 18:45 ` [PATCH 6/7] sky2: add new chip ids Stephen Hemminger
2007-02-06 18:45 ` [PATCH 7/7] sky2: version 1.12 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206215256.GA28967@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.