Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files

From: Oleg Verych <olecom@flower.upol.cz>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	Bastian Blank <bastian@waldi.eu.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files
Date: Wed, 7 Feb 2007 19:03:24 +0100	[thread overview]
Message-ID: <20070207180324.GE1160@flower.upol.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0702071537530.14457@scrub.home>

On Wed, Feb 07, 2007 at 03:39:38PM +0100, Roman Zippel wrote:
> Hi,
> 
> On Tue, 6 Feb 2007, Oleg Verych wrote:
> 
> > -nullstring :=
> > -space      := $(nullstring) # end of line
> > +pattern = ".*/localversion[^~]*"
> > +string  = $(shell cat /dev/null \
> > +	   `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)
> 
> Calling find here is overkill, if the same can be done with standard make 
> functions. I very much prefer to just add the damn $(notdir ...) and be 
> done with it.

Yes? I whould insist on it as separation of "meat" from "flies", i.e
paths from files, instead of (ugly) reparsing. But you know better.

Thanks.

____