All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ewan Mellor <ewan@xensource.com>
To: Stefan Berger <stefanb@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] [XEN-API] Not raising an API error in VTPM destroy method
Date: Thu, 8 Feb 2007 15:53:24 +0000	[thread overview]
Message-ID: <20070208155324.GA2043@leeni.uk.xensource.com> (raw)
In-Reply-To: <1170891439.4978.2.camel@941e-2.watson.ibm.com>

On Wed, Feb 07, 2007 at 06:37:19PM -0500, Stefan Berger wrote:

> Don't return an API error if vTPM cannot be destroyed due to a running
> VM, but a value indicating failure instead. Adapt python code, libxen
> and documentation.
> 
> Signed-off-by: Stefan Berger <stefanb@us.ibm.com>

We have a separate error-returning mechanism -- you should be using that
rather than returning an error code.  Take a look at the end of
xenapi-datamodel.tex; the error code definitions are there.  In XendAPI.py,
you have xen_api_error available, which will marshall an error code and
arguments, and in xen/xm/messages there is a translation database for those
error messages.

Cheers,

Ewan.

  reply	other threads:[~2007-02-08 15:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 23:37 [PATCH] [XEN-API] Not raising an API error in VTPM destroy method Stefan Berger
2007-02-08 15:53 ` Ewan Mellor [this message]
2007-02-08 18:25   ` Stefan Berger
2007-02-08 19:00     ` Ewan Mellor
2007-02-08 19:07       ` Stefan Berger
2007-02-08 19:08       ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208155324.GA2043@leeni.uk.xensource.com \
    --to=ewan@xensource.com \
    --cc=stefanb@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.