All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: "James K. Love" <jlove@scires.com>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Floppy disk support for 9000 series (715, 755, etc.) workstations.
Date: Thu, 8 Feb 2007 10:38:08 -0700	[thread overview]
Message-ID: <20070208173808.GL13101__35519.0112641596$1416624278$gmane$org@parisc-linux.org> (raw)
In-Reply-To: <45CB5C9D.1070601@scires.com>

On Thu, Feb 08, 2007 at 12:23:41PM -0500, James K. Love wrote:
> I finally figured some of this out.  I ported the MACH flexible scsi disk
> code over to the 2.6 kernel, and I can now mount/read/write with my HP TEAC 
> FC-1
> drive.  The modifications I made were inside the scsi device (sd) driver, 
> which
> is similar to where they were inside the MACH kernel.  This is obviously not
> ideal, since the device major is for a scsi disk, but the drive is really a
> floppy.  This breaks some user-space floppy apps like fdformat.  There 
> really
> should be a new floppy driver similar to the cdrom driver, but these 
> changes may
> not work with any other scsi floppy drive (are there any others?).  I only 
> have
> a few HP OEM TEAC revs to test with here.
> 
> Bottom line... The scsi disk driver could be patched, but it may only 
> provide
> partial/experimental support for this drive without extensive changes.  I'm
> traditionally a user-space developer, so I'd appreciate any advice/thoughts
> before I get knee deep.  Also, if someone could pass along a few links to 
> some
> procedural docs about properly submitting kernel code/patches, I'd really
> appreciate it.

That's good work!

Could you post the patch to sd.c here?  I, and others, can look it over,
critique it, and help polish it before you submit it to the linux-scsi
list.  Or if you're brave, you could send it straight to linux-scsi
(there's about 3 of us who're on both lists, so you may well see feedback
>from a familiar name anyway).

Without looking at the source code to check, I suspect the fdformat code
is trying ioctls that are implemented in floppy.c and we might want to
emulate them in sd.c if the device is a floppy.

We certainly could do a sf.c that's similar in spirit to sr, sd, st, etc.
That might be the right approach, or it might be best to extend sd.
The SCSI-2 spec says that floppy drives are Direct Access Devices (which
sd normally drives).  But then, if we want to make it appear to Linux as
if it's a floppy drive, sf.c would be the right way to go.  If we want
to support machines with both a scsi floppy and a regular floppy at the
same time (and such machines can certainly be constructed; eg a C3000
with a SuperIO floppy and a scsi floppy, or a 725 with a Lasi floppy and
a scsi floppy), then I think we have to use the 'sd' approach to avoid
the drivers fighting over the major number.  A disadvantage to that is
the lack of different device nodes for different sector sizes ... otoh,
some may see that as an advantage ;-)

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

  parent reply	other threads:[~2007-02-08 17:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45B67554.6010208@scires.com>
2007-01-24 16:28 ` [parisc-linux] Floppy disk support for 9000 series (715, 755, etc.) workstations Grant Grundler
     [not found] ` <20070124162810.GA31075@colo.lackof.org>
2007-02-08 17:23   ` James K. Love
     [not found]   ` <45CB5C9D.1070601@scires.com>
2007-02-08 17:38     ` Matthew Wilcox [this message]
     [not found]     ` <20070208173808.GL13101@parisc-linux.org>
2007-02-08 20:08       ` James K. Love
     [not found]       ` <45CB8357.2050703@scires.com>
2007-02-08 20:11         ` Matthew Wilcox
2007-03-05 22:17       ` [parisc-linux] [PATCH] sd: Adds flexible disk (TEAC FC-1, scsi-floppy) support to scsi disk driver James K. Love
     [not found]       ` <45EC9702.9080107@scires.com>
2007-03-08  6:53         ` Grant Grundler
     [not found]         ` <20070308065323.GB26641@colo.lackof.org>
2007-03-08 15:04           ` James K. Love
     [not found]           ` <45F0260A.7080306@scires.com>
2007-03-08 18:26             ` Grant Grundler
     [not found]             ` <20070308182601.GA18689@colo.lackof.org>
2007-03-09 15:51               ` James K. Love
2007-01-23 20:51 [parisc-linux] Floppy disk support for 9000 series (715, 755, etc.) workstations James K. Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20070208173808.GL13101__35519.0112641596$1416624278$gmane$org@parisc-linux.org' \
    --to=matthew@wil.cx \
    --cc=jlove@scires.com \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.