All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jeff Garzik <jeff@garzik.org>, Divy Le Ray <divy@chelsio.com>,
	Steve Wise <swise@opengridcomputing.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb3 - convert to user struct device instead of class_device
Date: Thu, 8 Feb 2007 13:19:11 -0800	[thread overview]
Message-ID: <20070208211911.GA20988@suse.de> (raw)
In-Reply-To: <adalkj8l6vb.fsf@cisco.com>

On Thu, Feb 08, 2007 at 12:41:28PM -0800, Roland Dreier wrote:
> Commit 43cb76d9 ("Network: convert network devices to use struct
> device instead of class_device") breaks the just-merged cxgb3 driver,
> since the code that was merged predates the change and was not in the
> tree when Greg made the change.
> 
> This patch fixes cxgb3 to build with the change.  It also removes the
> private to_net_dev() macro and changes the use of bare netdev->priv in
> favor of netdev_priv(netdev) in the sysfs attribute functions.
> 
> I tested this on my system which has cxgb3 hardware, and it looks like
> all the sysfs files are created correctly and contain sane-looking
> values, although I don't actually know how to test that every
> attribute is working as it should.

If it compiles with no warnings, it should be safe.

> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

But I think Jeff already has a patch in the queue that makes this very
change :)

thanks,

greg k-h

  reply	other threads:[~2007-02-08 21:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 20:41 [PATCH] cxgb3 - convert to user struct device instead of class_device Roland Dreier
2007-02-08 21:19 ` Greg KH [this message]
2007-02-08 21:31   ` Roland Dreier
2007-02-08 21:46     ` Jeff Garzik
2007-02-08 22:02       ` Roland Dreier
2007-02-08 23:48         ` Kumar Gala
2007-02-09  3:24     ` Divy Le Ray
2007-02-09  4:13       ` Roland Dreier
2007-02-09  5:21         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208211911.GA20988@suse.de \
    --to=gregkh@suse.de \
    --cc=divy@chelsio.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.