From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@muc.de>,
virtualization <virtualization@lists.osdl.org>,
Paul Mackerras <paulus@samba.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 6/10] lguest code: the little linux hypervisor.
Date: Fri, 9 Feb 2007 01:35:18 -0800 [thread overview]
Message-ID: <20070209013518.e75d5036.akpm@linux-foundation.org> (raw)
In-Reply-To: <1171012827.2718.42.camel@localhost.localdomain>
On Fri, 09 Feb 2007 20:20:27 +1100 Rusty Russell <rusty@rustcorp.com.au> wrote:
> +#define log(...) \
> + do { \
> + mm_segment_t oldfs = get_fs(); \
> + char buf[100]; \
> + sprintf(buf, "lguest:" __VA_ARGS__); \
> + set_fs(KERNEL_DS); \
> + sys_write(1, buf, strlen(buf)); \
> + set_fs(oldfs); \
> + } while(0)
Due to gcc shortcomings, each instance of this will chew an additional 100
bytes of stack. Unless they fixed it recently. Is a bit of a timebomb. I
guess ksaprintf() could be used.
It also looks a bit, umm, innovative.
next prev parent reply other threads:[~2007-02-09 9:35 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 9:11 [PATCH 0/10] lguest Rusty Russell
2007-02-09 9:11 ` Rusty Russell
2007-02-09 9:14 ` [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler Rusty Russell
2007-02-09 9:15 ` [PATCH 2/10] lguest: Export symbols for lguest as a module Rusty Russell
2007-02-09 9:32 ` Andi Kleen
2007-02-09 12:06 ` Rusty Russell
2007-02-09 13:58 ` Andi Kleen
2007-02-10 11:39 ` Rusty Russell
2007-02-09 9:17 ` [PATCH 3/10] lguest: Expose get_futex_key, get_key_refs and drop_key_refs Rusty Russell
2007-02-09 9:18 ` [PATCH 4/10] lguest: Initialize esp0 properly all the time Rusty Russell
2007-02-09 9:19 ` [PATCH 5/10] Make hvc_console.c compile on non-PowerPC Rusty Russell
2007-02-09 9:19 ` Rusty Russell
2007-02-09 9:20 ` [PATCH 6/10] lguest code: the little linux hypervisor Rusty Russell
2007-02-09 9:22 ` [PATCH 7/10] lguest: Simple lguest network driver Rusty Russell
2007-02-09 9:23 ` [PATCH 8/10] lguest: console driver Rusty Russell
2007-02-09 9:24 ` [PATCH 9/10] lguest: block driver Rusty Russell
2007-02-09 9:25 ` [PATCH 10/10] lguest: documentatation including example launcher Rusty Russell
2007-02-09 9:35 ` Andrew Morton [this message]
2007-02-09 11:00 ` [PATCH 6/10] lguest code: the little linux hypervisor Rusty Russell
2007-02-09 11:13 ` Zachary Amsden
2007-02-09 11:50 ` Andi Kleen
2007-02-09 11:54 ` Zachary Amsden
2007-02-09 11:57 ` Andi Kleen
2007-02-09 12:08 ` Zachary Amsden
2007-02-09 22:29 ` David Miller
2007-02-09 10:09 ` Andi Kleen
2007-02-09 12:39 ` Rusty Russell
2007-02-09 13:57 ` Andi Kleen
2007-02-09 15:01 ` Rusty Russell
2007-02-09 14:17 ` Sam Ravnborg
2007-02-09 15:23 ` Rusty Russell
2007-02-12 13:34 ` [q] kbuild for private asm-offsets (Re: [PATCH 6/10] lguest code: the little linux hypervisor.) Oleg Verych
2007-02-12 17:24 ` Andi Kleen
2007-02-12 21:41 ` Sam Ravnborg
2007-02-12 23:41 ` Rusty Russell
2007-02-13 3:10 ` Oleg Verych
2007-02-13 3:10 ` Oleg Verych
2007-02-16 15:55 ` [pp] kbuild: lguest with private asm-offsets (and some bloat) Oleg Verych
2007-02-16 15:59 ` [pp] kbuild: asm-offsets generalized Oleg Verych
2007-02-16 18:56 ` Sam Ravnborg
2007-02-16 21:56 ` Oleg Verych
2007-02-17 4:43 ` Rusty Russell
2007-02-17 5:33 ` Oleg Verych
2007-04-01 20:42 ` Sam Ravnborg
2007-04-01 21:08 ` Oleg Verych
2007-04-01 21:03 ` Sam Ravnborg
2007-02-09 10:55 ` [PATCH 6a/10] lguest: Config and headers Rusty Russell
2007-02-09 10:56 ` [PATCH 6b/10] lguest: the host code (lg.ko) Rusty Russell
2007-02-09 10:57 ` [PATCH 6c/10] lguest: the guest code Rusty Russell
2007-02-09 10:58 ` [PATCH 6d/10] lguest: the Makefiles Rusty Russell
2007-02-09 17:06 ` [PATCH 6c/10] lguest: the guest code Len Brown
2007-02-09 17:14 ` James Morris
2007-02-09 17:49 ` Len Brown
2007-02-09 23:48 ` [PATCH 11/10] lguest: use disable_acpi() Rusty Russell
2007-02-09 9:31 ` [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler Andi Kleen
2007-02-09 11:52 ` Rusty Russell
2007-02-09 20:49 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209013518.e75d5036.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.