From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbXBIVv1 (ORCPT ); Fri, 9 Feb 2007 16:51:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752634AbXBIVv0 (ORCPT ); Fri, 9 Feb 2007 16:51:26 -0500 Received: from smtp.osdl.org ([65.172.181.24]:48689 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbXBIVvZ (ORCPT ); Fri, 9 Feb 2007 16:51:25 -0500 Date: Fri, 9 Feb 2007 13:33:55 -0800 From: Andrew Morton To: Roman Zippel Cc: Heiko Carstens , Alon Bar-Lev , linux-kernel@vger.kernel.org, bwalle@suse.de, rmk+lkml@arm.linux.org.uk, spyro@f2s.com, davej@codemonkey.org.uk, hpa@zytor.com, Riley@williams.name, tony.luck@intel.com, geert@linux-m68k.org, ralf@linux-mips.org, matthew@wil.cx, grundler@parisc-linux.org, kyle@parisc-linux.org, paulus@samba.org, schwidefsky@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net, uclinux-v850@lsi.nec.co.jp, ak@muc.de, vojtech@suse.cz, chris@zankel.net, len.brown@intel.com, lenb@kernel.org, herbert@gondor.apana.org.au, viro@zeniv.linux.org.uk, bzolnier@gmail.com, dmitry.torokhov@gmail.com, dtor@mail.ru, jgarzik@pobox.com, linux-mm@kvack.org, dwmw2@infradead.org, patrick@tykepenguin.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, philb@gnu.org, tim@cyberelk.net, andrea@suse.de, ambx1@neo.rr.com, James.Bottomley@steeleye.com, linux-serial@vger.kernel.org Subject: Re: [PATCH 00/34] __initdata cleanup Message-Id: <20070209133355.d5df1ab5.akpm@linux-foundation.org> In-Reply-To: References: <200702091711.34441.alon.barlev@gmail.com> <20070209170005.GA8500@osiris.ibm.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Feb 2007 18:37:34 +0100 (CET) Roman Zippel wrote: > Hi, > > On Fri, 9 Feb 2007, Heiko Carstens wrote: > > > And indeed all the __initdata annotated local and global variables on > > s390 are in the init.data section. So I'm wondering what this patch > > series is about. Or I must have missed something. > > I think it reaches back to times when gcc 2.7.* was still supported, which > does behave as described in the documentation. gcc 2.95 and newer don't > require explicit initialization anymore, so this has become a non-issue. > Yes, nobody's been observing any problems arising from this, and if this memory was really uninitialised, people would be hitting problems. I don't want to have to require that all __attribute__((section)) storage be initialised - people will surely forget to do it and things will slip through. If we really do have a problem here it'd be better to fix it in some central and global fashion: either by ensuring that each architecture's startup code will zero this memory or by some compiler/linker option such as -fno-common. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 00/34] __initdata cleanup Date: Fri, 9 Feb 2007 13:33:55 -0800 Message-ID: <20070209133355.d5df1ab5.akpm@linux-foundation.org> References: <200702091711.34441.alon.barlev@gmail.com> <20070209170005.GA8500@osiris.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.osdl.org ([65.172.181.24]:48689 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbXBIVvZ (ORCPT ); Fri, 9 Feb 2007 16:51:25 -0500 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Roman Zippel Cc: Heiko Carstens , Alon Bar-Lev , linux-kernel@vger.kernel.org, bwalle@suse.de, rmk+lkml@arm.linux.org.uk, spyro@f2s.com, davej@codemonkey.org.uk, hpa@zytor.com, Riley@williams.name, tony.luck@intel.com, geert@linux-m68k.org, ralf@linux-mips.org, matthew@wil.cx, grundler@parisc-linux.org, kyle@parisc-linux.org, paulus@samba.org, schwidefsky@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net, uclinux-v850@lsi.nec.co.jp, ak@muc.de, vojtech@suse.cz, chris@zankel.net, len.brown@intel.com, lenb@kernel.org, herbert@gondor.apana.org.au, viro@zeniv.linux.org.uk, bzolnier@gmail.com, dmitry.torokhov@gmail.com, dtor@mail.ru, jgarzik@pobox.com, linux-mm@kvack.org, dwmw2@infradead.org, patrick@tykepenguin.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, philb@gnu.org, tim@cyberelk.net, andrea@suse.de, ambx1@neo.rr.co On Fri, 9 Feb 2007 18:37:34 +0100 (CET) Roman Zippel wrote: > Hi, > > On Fri, 9 Feb 2007, Heiko Carstens wrote: > > > And indeed all the __initdata annotated local and global variables on > > s390 are in the init.data section. So I'm wondering what this patch > > series is about. Or I must have missed something. > > I think it reaches back to times when gcc 2.7.* was still supported, which > does behave as described in the documentation. gcc 2.95 and newer don't > require explicit initialization anymore, so this has become a non-issue. > Yes, nobody's been observing any problems arising from this, and if this memory was really uninitialised, people would be hitting problems. I don't want to have to require that all __attribute__((section)) storage be initialised - people will surely forget to do it and things will slip through. If we really do have a problem here it'd be better to fix it in some central and global fashion: either by ensuring that each architecture's startup code will zero this memory or by some compiler/linker option such as -fno-common. From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 9 Feb 2007 13:33:55 -0800 From: Andrew Morton Subject: Re: [PATCH 00/34] __initdata cleanup Message-Id: <20070209133355.d5df1ab5.akpm@linux-foundation.org> In-Reply-To: References: <200702091711.34441.alon.barlev@gmail.com> <20070209170005.GA8500@osiris.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Roman Zippel Cc: Heiko Carstens , Alon Bar-Lev , linux-kernel@vger.kernel.org, bwalle@suse.de, rmk+lkml@arm.linux.org.uk, spyro@f2s.com, davej@codemonkey.org.uk, hpa@zytor.com, Riley@williams.name, tony.luck@intel.com, geert@linux-m68k.org, ralf@linux-mips.org, matthew@wil.cx, grundler@parisc-linux.org, kyle@parisc-linux.org, paulus@samba.org, schwidefsky@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net, uclinux-v850@lsi.nec.co.jp, ak@muc.de, vojtech@suse.cz, chris@zankel.net, len.brown@intel.com, lenb@kernel.org, herbert@gondor.apana.org.au, viro@zeniv.linux.org.uk, bzolnier@gmail.com, dmitry.torokhov@gmail.com, dtor@mail.ru, jgarzik@pobox.com, linux-mm@kvack.org, dwmw2@infradead.org, patrick@tykepenguin.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, philb@gnu.org, tim@cyberelk.net, andrea@suse.de, ambx1@neo.rr.com, James.Bottomley@steeleye.com, linux-serial@vger.kernel.org List-ID: On Fri, 9 Feb 2007 18:37:34 +0100 (CET) Roman Zippel wrote: > Hi, > > On Fri, 9 Feb 2007, Heiko Carstens wrote: > > > And indeed all the __initdata annotated local and global variables on > > s390 are in the init.data section. So I'm wondering what this patch > > series is about. Or I must have missed something. > > I think it reaches back to times when gcc 2.7.* was still supported, which > does behave as described in the documentation. gcc 2.95 and newer don't > require explicit initialization anymore, so this has become a non-issue. > Yes, nobody's been observing any problems arising from this, and if this memory was really uninitialised, people would be hitting problems. I don't want to have to require that all __attribute__((section)) storage be initialised - people will surely forget to do it and things will slip through. If we really do have a problem here it'd be better to fix it in some central and global fashion: either by ensuring that each architecture's startup code will zero this memory or by some compiler/linker option such as -fno-common. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org