All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Brian D. Behlendorf" <behlendorf1@llnl.gov>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, adilger@clusterfs.com,
	behlendorf1@llnl.gov, wartens2@llnl.gov
Subject: e2fsprogs coverity patch <cid-28.diff>
Date: Fri, 9 Feb 2007 18:11:24 -0800	[thread overview]
Message-ID: <200702100211.l1A2BOQM007246@igsi.llnl.gov> (raw)

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see 
if it would identify any significant bugs.  The analysis
turned up 38 mostly minor issues which are enumerated here
with patches.  We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Thanks,
Brian Behlendorf <behlendorf1@llnl.gov>, and
Herb Wartens <wartens2@llnl.gov>

-----------------------------------------------------------------------------
Coverity ID: 28: Resource Leak

block_buf must be freed on return from this function.  The other
potential resource leaks in this function are handled by calling exit().

Index: e2fsprogs+chaos/misc/e2image.c
===================================================================
--- e2fsprogs+chaos.orig/misc/e2image.c
+++ e2fsprogs+chaos/misc/e2image.c
@@ -540,6 +540,7 @@ static void write_raw_image_file(ext2_fi
 	}
 	use_inode_shortcuts(fs, 0);
 	output_meta_data_blocks(fs, fd);
+	free(block_buf);
 }
 
 static void install_image(char *device, char *image_fn, int raw_flag)

                 reply	other threads:[~2007-02-10  2:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702100211.l1A2BOQM007246@igsi.llnl.gov \
    --to=behlendorf1@llnl.gov \
    --cc=adilger@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=wartens2@llnl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.