All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Brian D. Behlendorf" <behlendorf1@llnl.gov>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, adilger@clusterfs.com,
	behlendorf1@llnl.gov, wartens2@llnl.gov
Subject: e2fsprogs coverity patch <cid-33.diff>
Date: Fri, 9 Feb 2007 18:11:29 -0800	[thread overview]
Message-ID: <200702100211.l1A2BTRb007321@igsi.llnl.gov> (raw)

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see 
if it would identify any significant bugs.  The analysis
turned up 38 mostly minor issues which are enumerated here
with patches.  We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Thanks,
Brian Behlendorf <behlendorf1@llnl.gov>, and
Herb Wartens <wartens2@llnl.gov>

-----------------------------------------------------------------------------
Coverity ID: 33: Resource Leak

The memory allocated by buf is not reclaimed.  This patch
addresses the issue.

Index: e2fsprogs+chaos/misc/util.c
===================================================================
--- e2fsprogs+chaos.orig/misc/util.c
+++ e2fsprogs+chaos/misc/util.c
@@ -176,7 +176,7 @@ void check_mount(const char *device, int
 
 void parse_journal_opts(const char *opts)
 {
-	char	*buf, *token, *next, *p, *arg;
+	char	*buf = NULL, *token, *next, *p, *arg;
 	int	len;
 	int	journal_usage = 0;
 
@@ -234,8 +234,11 @@ void parse_journal_opts(const char *opts
 			"\tdevice=<journal device>\n\n"
 			"The journal size must be between "
 			"1024 and 102400 filesystem blocks.\n\n"), stderr);
+		free(buf);
 		exit(1);
 	}
+
+	free(buf);
 }	
 
 /*

             reply	other threads:[~2007-02-10  2:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10  2:11 Brian D. Behlendorf [this message]
2007-05-29 18:49 ` e2fsprogs coverity patch <cid-33.diff> Eric Sandeen
2007-05-29 20:51   ` Andreas Dilger
2007-05-29 20:56     ` Eric Sandeen
2007-05-29 22:20       ` Theodore Tso
2007-05-29 23:10         ` Andreas Dilger
2007-05-31 15:43           ` Theodore Tso
2007-05-30  2:01         ` Eric Sandeen
2007-05-31 15:31     ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702100211.l1A2BTRb007321@igsi.llnl.gov \
    --to=behlendorf1@llnl.gov \
    --cc=adilger@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=wartens2@llnl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.