All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [patch] linux/io.h: forward declare struct pci_dev
Date: Sat, 10 Feb 2007 12:45:50 +0100	[thread overview]
Message-ID: <20070210114550.GC12642@osiris.boeblingen.de.ibm.com> (raw)

From: Heiko Carstens <heiko.carstens@de.ibm.com>

9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this:

  CC      arch/s390/mm/ioremap.o
In file included from arch/s390/mm/ioremap.c:18:
include/linux/io.h:46:
	warning: "struct pci_dev" declared inside parameter list
include/linux/io.h:46:
	warning: its scope is only this definition or declaration,
		 which is probably not what you want

Guess it's time to get rid of ioremap.c on s390 if possible...

Cc: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 include/linux/io.h |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6/include/linux/io.h
===================================================================
--- linux-2.6.orig/include/linux/io.h
+++ linux-2.6/include/linux/io.h
@@ -22,6 +22,7 @@
 #include <asm/io.h>
 #include <asm/page.h>
 
+struct pci_dev;
 struct device;
 
 void __iowrite32_copy(void __iomem *to, const void *from, size_t count);

             reply	other threads:[~2007-02-10 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 11:45 Heiko Carstens [this message]
2007-02-11  3:49 ` Christoph Hellwig
2007-02-11  6:26   ` Tejun Heo
2007-02-11  6:34     ` Al Viro
2007-02-11  6:46       ` Tejun Heo
2007-02-11  6:55       ` Randy Dunlap
2007-02-11  7:10       ` Christoph Hellwig
2007-02-11  8:21         ` Al Viro
2007-02-11 15:09       ` Jeff Garzik
2007-02-11 15:31       ` Heiko Carstens
2007-02-11 15:41         ` [PATCH] sort the devres mess out Al Viro
2007-02-11 15:49           ` Jeff Garzik
2007-02-11 22:16             ` Roland Dreier
2007-02-12  5:30               ` [PATCH] ia64: Fix noncoherent DMA API so devres builds Roland Dreier
2007-02-12 21:06                 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070210114550.GC12642@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch] linux/io.h: forward declare struct pci_dev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.