All of lore.kernel.org
 help / color / mirror / Atom feed
From: Blaisorblade <blaisorblade@yahoo.it>
To: git@vger.kernel.org, Ryan Anderson <ryan@michonline.com>
Subject: git-send-email: default values do not work
Date: Sat, 10 Feb 2007 18:15:45 +0100	[thread overview]
Message-ID: <200702101815.45201.blaisorblade@yahoo.it> (raw)

I'm using git v1.4.4.4, and trying to use directly git-send-email on plain 
files.

bug #1 (default values when prompting do not work)

According to git-send-email documentation, it should suggest default values 
when prompting the user.

However it does not, since ->readline does not accept a default value.

I've verified this in man Term\:\:ReadLine and by looking 
at /usr/share/perl/5.8.7/Term/ReadLine.pm, and with the perl debugger - the 
default is correctly calculated but not printed. At least with my perl 
(5.8.7, from up-to-date Ubuntu 6.06 LTS).

git-send-email should instead say "press Enter for default [$default]" and 
behave correspondingly.

bug #2 (subject line is cut away but ignored)

Additionally, I was sending a patch starting with (on 1st line):

Kconfig: FAULT_INJECTION can be selected only if LOCKDEP is enabled.

'Kconfig:' is interpreted as a mbox parameter, and ignored, and that line is 
removed from the email.

This should be documented and pitfall, and probably the user should be allowed 
to override that.

Thanks.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 

                 reply	other threads:[~2007-02-10 17:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702101815.45201.blaisorblade@yahoo.it \
    --to=blaisorblade@yahoo.it \
    --cc=git@vger.kernel.org \
    --cc=ryan@michonline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.