From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 11 Feb 2007 11:23:39 +0100 Subject: [U-Boot-Users] [PATCH0/2] Re-do the patch for adding DO_SYNC in flash_write_cmd In-Reply-To: Your message of "Sat, 10 Feb 2007 20:34:09 CST." <45CE80A1.5050206@freescale.com> Message-ID: <20070211102339.11426352676@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <45CE80A1.5050206@freescale.com> you wrote: > > > #define sync() __asm__ __volatile__ ("sync" : : : "memory"); > > I like this idea, but is that semicolon supposed to be there? Shouldn't > we make it an inline function instead of a macro? No, and yes, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Felson's Law: To steal ideas from one person is plagiarism; to steal from many is research.