All of
 help / color / mirror / Atom feed
From: Al Viro <>
To: Alexey Dobriyan <>
Cc: Andrew Morton <>,
	Alexey Dobriyan <>,,
Subject: Re: [PATCH v4] Fix rmmod/read/write races in /proc entries
Date: Sun, 11 Feb 2007 20:34:26 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Does it pass everyone's bullshit detectors?
Nice, but incomplete.  What we need to add is
	* procfs-specific file_operations shared by all regular files
on procfs.  Stuff in there would call methods from pde->proc_fops,
after having done the same kind of exclusion you are currently doing
in proc_file_read(),
	* always set ->f_op of regular files on procfs to that sucker.
Don't reset it to NULL during removal.
	* now that exclusion is done in wrappers, no need to do it in

That'll solve the rest of issues.  Eventually we might want to divorce
->proc_fops from file_operations (and trim it down), but that's a separate

  reply	other threads:[~2007-02-11 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 13:20 [PATCH v3] Fix rmmod/read/write races in /proc entries Alexey Dobriyan
2007-02-09  9:00 ` Andrew Morton
2007-02-11 20:23   ` [PATCH v4] " Alexey Dobriyan
2007-02-11 20:34     ` Al Viro [this message]
2007-02-13  6:35     ` Andrew Morton
2007-02-13 16:16       ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.