All of lore.kernel.org
 help / color / mirror / Atom feed
* [POWERPC] Wire up sys_getcpu
@ 2007-02-12 11:09 Stephen Rothwell
  2007-02-12 12:43 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2007-02-12 11:09 UTC (permalink / raw)
  To: paulus; +Cc: ppc-dev, Arnd Bergmann


Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/asm-powerpc/systbl.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Arnd, should this be _SPU?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff --git a/include/asm-powerpc/systbl.h b/include/asm-powerpc/systbl.h
index 97b4354..418e5c7 100644
--- a/include/asm-powerpc/systbl.h
+++ b/include/asm-powerpc/systbl.h
@@ -305,3 +305,4 @@ SYSCALL_SPU(faccessat)
 COMPAT_SYS_SPU(get_robust_list)
 COMPAT_SYS_SPU(set_robust_list)
 COMPAT_SYS(move_pages)
+SYSCALL_SPU(getcpu)
-- 
1.4.4.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [POWERPC] Wire up sys_getcpu
  2007-02-12 11:09 [POWERPC] Wire up sys_getcpu Stephen Rothwell
@ 2007-02-12 12:43 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2007-02-12 12:43 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Jeremy Kerr, ppc-dev, paulus

On Monday 12 February 2007 12:09, Stephen Rothwell wrote:
>=20
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> =A0include/asm-powerpc/systbl.h | =A0 =A01 +
> =A01 files changed, 1 insertions(+), 0 deletions(-)
>=20
> Arnd, should this be _SPU?

Good question. There is nothing wrong with having the SPU call this,
i.e. it won't break stuff. The question is more if it should return
an SPU number instead of a CPU number. I've had people ask for
a feature like that in the past.

The node information returned from the call usually is the same for
the CPU and the SPU, but we don't guarantee that, unless the user
has specified node affinity.

I don't see a 'right' answer for your question, but I'd say let's
not forbid the user to call it and make it _SPU, even if it is
pointless.

	Arnd <><

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-12 12:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-12 11:09 [POWERPC] Wire up sys_getcpu Stephen Rothwell
2007-02-12 12:43 ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.