From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030196AbXBLVq1 (ORCPT ); Mon, 12 Feb 2007 16:46:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030195AbXBLVq0 (ORCPT ); Mon, 12 Feb 2007 16:46:26 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:44723 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030192AbXBLVq0 (ORCPT ); Mon, 12 Feb 2007 16:46:26 -0500 From: "Rafael J. Wysocki" To: nigel@nigel.suspend2.net Subject: Re: NAK new drivers without proper power management? Date: Mon, 12 Feb 2007 22:43:10 +0100 User-Agent: KMail/1.9.5 Cc: Pavel Machek , Manu Abraham , Willy Tarreau , Arjan van de Ven , LKML , tilman@imap.cc, Robert Hancock References: <1171059433.8675.195.camel@laptopd505.fenrus.org> <200702122201.01666.rjw@sisk.pl> <1171315453.4081.23.camel@nigel.suspend2.net> In-Reply-To: <1171315453.4081.23.camel@nigel.suspend2.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702122243.11801.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Monday, 12 February 2007 22:24, Nigel Cunningham wrote: > Hi. > > On Mon, 2007-02-12 at 22:01 +0100, Rafael J. Wysocki wrote: > > On Monday, 12 February 2007 21:58, Pavel Machek wrote: > > > Hi! > > > > > > > > > If all you need to do is say 'I don't need to do anything' and we have a > > > > > > shared function that does that, all we're talking about doing is adding > > > > > > to your struct pci_device (or whatever) > > > > > > > > > > > > .resume = generic_empty_resume; > > > > > > > > > > > > To me at least, that doesn't look awkward, and says cleanly and clearly > > > > > > that you've checked things over and decided you know what's required. > > > > > > > > > > Actually, I'd like it to be > > > > > > > > > > .resume = generic_empty_resume; /* Explain, why your driver needs no > > > > > resume */ > > > > > > > > Okay, but we can't define an empty .resume(), because, for example, the PCI's > > > > generic suspend/resume won't be called. > > > > > > PCI drivers should just do .resume = pci_generic_resume, explicitely. > > > > Well, I generally agree, but I think the idea with the "pm_safe" flag has some > > advantages. For example, the drivers that do define .suspend() and .resume() > > which don't work correctly could be flagged as not "pm_safe" until the problems > > are fixed. > > Oooh. Now I like that idea. Are you thinking of a document in > Documentation/power that describes why pm_safe is off, or comments in > the code itself? I think the code should be commented in the first place. Additionally, we can create a file or a directory under Documentation/power for documenting more complicated cases, if necessary. Greetings, Rafael