From: Jens Axboe <email@example.com> To: Rusty Russell <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, lkml - Kernel Mailing List <firstname.lastname@example.org>, virtualization <email@example.com> Subject: Re: [PATCH 7/8] lguest: trivial guest block driver Date: Tue, 13 Feb 2007 01:44:08 +0100 [thread overview] Message-ID: <20070213004408.GB3641@kernel.dk> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, Feb 13 2007, Rusty Russell wrote: > On Mon, 2007-02-12 at 16:01 +0100, Jens Axboe wrote: > > On Mon, Feb 12 2007, Rusty Russell wrote: > > > Thanks Jens!! > > > > My pleasure, it's not often you get to make that big a performance > > improvement with just a little few lines of change :-) > > *cough* I deliberately leave these low hanging fruit in lguest to > encourage people to hack on it. Really. *cough* :-) > > I guess you'll take changes to make this driver queuing as well? It's > > pretty important for good guest io performance as well. > > The question is whether the guest or host should queue. If you have > multiple guests sharing a disk in the hose, I would think that the host > is better off queuing. And this would seem to be the common case. You want queuing in the host, since for queuing to make a performance difference it needs to be propagated all the way down to the device. But you can't get queuing at the host level if the guest device doesn't allow it, you'd be serializing anyway. Well for writes you can, but not synchronous requests. Basically allow as much to be sent to the host as possible. > On my todo list is: > 1) Implement write barriers, (-> fsync in the host) > 2) Make the host userspace program (lguest) async rather than blocking, > 3) Allow multiple outstanding requests. > > Then it should be useful for other hypervisors. I completely agree with your prioritized list. -- Jens Axboe
next prev parent reply other threads:[~2007-02-13 0:43 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-12 3:32 [PATCH 1/7] cleanup: paravirt unhandled fallthrough Rusty Russell 2007-02-12 3:33 ` [PATCH 2/7] cleanup: Initialize esp0 properly all the time Rusty Russell 2007-02-12 3:34 ` [PATCH 3/7] cleanup: Make hvc_console.c compile on non-PowerPC Rusty Russell 2007-02-12 3:35 ` [PATCH 4/7] cleanup: Move mce_disabled to asm/mce.h Rusty Russell 2007-02-12 3:36 ` [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declaration from smpboot.c Rusty Russell 2007-02-12 3:37 ` [PATCH 6/7] cleanup: Remove extern declaration from mm/discontig.c, put in header Rusty Russell 2007-02-12 3:39 ` [PATCH 7/7] cleanup: make disable_acpi() valid w/o CONFIG_ACPI Rusty Russell 2007-02-12 3:41 ` [PATCH 1/2] lguest preparation: EXPORT_SYMBOL_GPL 5 functions Rusty Russell 2007-02-12 3:42 ` [PATCH 2/2] lguest preparation: expose futex infrastructure: get_futex_key, get_key_refs and drop_key_refs Rusty Russell 2007-02-12 3:44 ` [PATCH 1/8] lguest: Kconfig and headers Rusty Russell 2007-02-12 3:46 ` [PATCH 2/8] lguest: the host code (lg.ko) Rusty Russell 2007-02-12 3:48 ` [PATCH 3/8] lguest: Guest code Rusty Russell 2007-02-12 3:50 ` [PATCH 4/8] lguest: Makefile Rusty Russell 2007-02-12 3:52 ` [PATCH 5/8] lguest: trivial guest network driver Rusty Russell 2007-02-12 3:53 ` [PATCH 6/8] lguest: trivial guest console driver Rusty Russell 2007-02-12 3:54 ` [PATCH 7/8] lguest: trivial guest block driver Rusty Russell 2007-02-12 3:55 ` [PATCH 8/8] lguest: documentatation and example launcher Rusty Russell 2007-02-12 4:43 ` [PATCH 7/8] lguest: trivial guest block driver Jens Axboe 2007-02-12 5:27 ` Rusty Russell 2007-02-12 5:32 ` Jens Axboe 2007-02-12 5:33 ` Jens Axboe 2007-02-12 7:09 ` Rusty Russell 2007-02-12 7:09 ` Rusty Russell 2007-02-12 15:01 ` Jens Axboe 2007-02-13 0:25 ` Rusty Russell 2007-02-13 0:25 ` Rusty Russell 2007-02-13 0:44 ` Jens Axboe [this message] 2007-02-12 15:55 ` [PATCH 5/8] lguest: trivial guest network driver Herbert Xu 2007-02-13 2:15 ` Rusty Russell 2007-02-13 14:06 ` Herbert Xu 2007-02-14 4:47 ` Rusty Russell 2007-02-14 13:57 ` Herbert Xu 2007-02-14 23:00 ` Rusty Russell 2007-02-12 16:02 ` [PATCH 1/8] lguest: Kconfig and headers James Morris 2007-02-13 5:09 ` [PATCH 7/7] cleanup: make disable_acpi() valid w/o CONFIG_ACPI Len Brown 2007-02-12 9:16 ` [PATCH 5/7] cleanup: Rename cpu_gdt_descr and remove extern declaration from smpboot.c Zachary Amsden
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070213004408.GB3641@kernel.dk \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 7/8] lguest: trivial guest block driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.