From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + add-delay-around-sl82c105_reset_engine-calls.patch added to -mm tree Date: Mon, 12 Feb 2007 21:38:33 -0800 Message-ID: <200702130538.l1D5cXJ6022768@shell0.pdx.osdl.net> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.24]:55340 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161083AbXBMFif (ORCPT ); Tue, 13 Feb 2007 00:38:35 -0500 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: olaf@aepfle.de The patch titled add delay around sl82c105_reset_engine calls has been added to the -mm tree. Its filename is add-delay-around-sl82c105_reset_engine-calls.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: add delay around sl82c105_reset_engine calls From: Olaf Hering The hald media changed polling does really confuse things. Noone knows why the delays are needed, but they give us access to the CD. An udelay(50) will give reliable access to the drive, but there is still one (or more) EH reset. The drive works without EH resets with udelay(100). Signed-off-by: Olaf Hering Signed-off-by: Andrew Morton --- drivers/ata/pata_sl82c105.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN drivers/ata/pata_sl82c105.c~add-delay-around-sl82c105_reset_engine-calls drivers/ata/pata_sl82c105.c --- a/drivers/ata/pata_sl82c105.c~add-delay-around-sl82c105_reset_engine-calls +++ a/drivers/ata/pata_sl82c105.c @@ -187,7 +187,9 @@ static void sl82c105_bmdma_start(struct { struct ata_port *ap = qc->ap; + udelay(100); sl82c105_reset_engine(ap); + udelay(100); /* Set the clocks for DMA */ sl82c105_configure_dmamode(ap, qc->dev); @@ -216,6 +218,7 @@ static void sl82c105_bmdma_stop(struct a ata_bmdma_stop(qc); sl82c105_reset_engine(ap); + udelay(100); /* This will redo the initial setup of the DMA device to matching PIO timings */ _ Patches currently in -mm which might be from olaf@aepfle.de are origin.patch move-variables-in-drivers-macintosh-to-bss.patch add-delay-around-sl82c105_reset_engine-calls.patch cleanup-variable-usage-in-mesh-interrupt-handler.patch