All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <stefano.brivio@polimi.it>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH] fix error management in 8250_pci.c pciserial_resume_one
Date: Tue, 13 Feb 2007 11:30:10 +0100	[thread overview]
Message-ID: <20070213113010.27125d53@localhost> (raw)

  CC      drivers/serial/8250_pci.o
drivers/serial/8250_pci.c: In function 'pciserial_resume_one':
drivers/serial/8250_pci.c:1830: warning: ignoring return value of 'pci_enable_device', declared with attribute warn_unused_result

This patch fixes it.

Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
---

--- drivers/serial/8250_pci.c.orig	2007-02-13 11:04:03.579805618 +0100
+++ drivers/serial/8250_pci.c	2007-02-13 11:12:52.128454010 +0100
@@ -1819,6 +1819,7 @@
 static int pciserial_resume_one(struct pci_dev *dev)
 {
 	struct serial_private *priv = pci_get_drvdata(dev);
+	int rc;
 
 	pci_set_power_state(dev, PCI_D0);
 	pci_restore_state(dev);
@@ -1827,7 +1828,9 @@
 		/*
 		 * The device may have been disabled.  Re-enable it.
 		 */
-		pci_enable_device(dev);
+		rc = pci_enable_device(dev);
+		if (rc)
+			return rc;
 
 		pciserial_resume_ports(priv);
 	}

             reply	other threads:[~2007-02-13 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13 10:30 Stefano Brivio [this message]
2007-02-13 10:54 ` [PATCH] fix error management in 8250_pci.c pciserial_resume_one Russell King
2007-02-13 11:18 ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070213113010.27125d53@localhost \
    --to=stefano.brivio@polimi.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.