From: Jakub Jelinek <jakub@redhat.com>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Marcel Siegert <mws@linuxtv.org>,
Arjan van de Ven <arjan@infradead.org>,
mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org
Subject: Re: dvb shared datastructure bug?
Date: Tue, 13 Feb 2007 06:35:52 -0500 [thread overview]
Message-ID: <20070213113552.GL22959@devserv.devel.redhat.com> (raw)
In-Reply-To: <1a297b360702130314i3b67a828v804ddb85dc975101@mail.gmail.com>
On Tue, Feb 13, 2007 at 03:14:23PM +0400, Manu Abraham wrote:
> >thanks for pointing out this issue.
> >
> >attached find a patch that fixes the problem.
> >
> >@mauro - please pull changeset a7ac92d208fe
> > dvbdev: fix illegal re-usage of fileoperations struct
> >
> >from http://www.linuxtv.org/hg/~mws/v4l-dvb-fixtree
> >
>
> Ack'd-by: Manu Abraham <manu@linuxtv.org>
Wouldn't it be better to kmalloc both struct dvb_device and
struct file_operations together instead of doing 2 separate allocations?
struct dvd_device_plus_fops
{
struct dvb_device dev;
struct file_operations fops;
} *dev_fops = kmalloc (sizeof (struct dvd_device_plus_fops), GFP_KERNEL);
*pdvbdev = dvbdev = (struct dvb_device *)dev_fops;
if (dev_fops == NULL)
error handling;
memset (&dev_fops->fops, 0, sizeof (dev_fops->fops));
...
dvbdev->fops = &dev_fops->fops;
Jakub
next prev parent reply other threads:[~2007-02-13 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 7:47 dvb shared datastructure bug? Arjan van de Ven
2007-02-13 8:49 ` [v4l-dvb-maintainer] " Manu Abraham
2007-02-13 11:04 ` Marcel Siegert
2007-02-13 11:14 ` Manu Abraham
2007-02-13 11:35 ` Jakub Jelinek [this message]
2007-02-13 12:02 ` Marcel Siegert
2007-02-13 13:09 ` [v4l-dvb-maintainer] " Trent Piepho
2007-02-13 13:21 ` Marcel Siegert
2007-02-13 13:21 ` Manu Abraham
2007-02-13 11:35 ` Arjan van de Ven
2007-02-13 13:05 ` Marcel Siegert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213113552.GL22959@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=abraham.manu@gmail.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mws@linuxtv.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.