From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 14 Feb 2007 11:22:10 +1100 From: David Gibson To: Segher Boessenkool Subject: Re: [PATCH 15/16] Add device tree for Ebony Message-ID: <20070214002210.GE11491@localhost.localdomain> References: <20070213061026.5837FDDDE9@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Feb 13, 2007 at 09:08:52PM +0100, Segher Boessenkool wrote: > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + PowerPC,440GP { > > PowerPC,440GP@0 Hmm.. yeah, I'll fix that. > > + clock-frequency = <5F5E100>; /* 100MHz FIXME: poke in zImage */ > > + timebase-frequency = <5F5E100>; /* 100MHz FIXME: wrong, poke in > > zImage */ > > Can't you use decimal for these? dtc doesn't support decimal cells at present. Suggest a good syntax for doing it, and I'll add the feature. > > + UIC0: interrupt-controller { /* UIC0 */ > > > + #address-cells = <0>; > > + #size-cells = <0>; > > #address-cells = 0 never makes sense. Why not? Children of this node have and need no reg property, and no meaningful address. Sounds like #address-cells = 0 to me. > > + plb { > > + device_type = "soc"; > > + compatible = "ibm,plb-440gp", "ibm,plb4"; > > + ranges; > > You need a #address-cells, #size-cells here. Why? The values inherited from the root node are perfectly ok here. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson